Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag and drop training, from input box #1167

Closed
dartpain opened this issue Sep 30, 2024 · 23 comments · Fixed by #1463
Closed

Drag and drop training, from input box #1167

dartpain opened this issue Sep 30, 2024 · 23 comments · Fixed by #1463
Assignees
Labels
enhancement New feature or request frontend good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed javascript Pull requests that update Javascript code

Comments

@dartpain
Copy link
Contributor

Basically should trigger from file training process once a user drags and drops a file into the input box

@dartpain dartpain added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed javascript Pull requests that update Javascript code hacktoberfest frontend labels Sep 30, 2024
@sahil9001
Copy link
Contributor

Hey, can you please assign this to me?

@sahil9001
Copy link
Contributor

Just wanted to ask, wouldn't this be cost inefficient? Like a user might just drop the file accidentally and the system would train on it. I feel that it should be trained when user submits the file to the system instead of dropping it directly.

Please let me know if you have any reasoning to this

@dartpain
Copy link
Contributor Author

dartpain commented Oct 1, 2024

Im not sure may people put things into the input box, even on github it assumes the your are uploading an attachment. Would agree if it was a larger area.

@sahil9001
Copy link
Contributor

Im not sure may people put things into the input box, even on github it assumes the your are uploading an attachment. Would agree if it was a larger area.

But that's upload, right? Wouldn't training consume COGS/cost to DocsGPT with no reason? Assuming if a user uploads a big text file (1M Tokens), and then removes, let's say this happens 10 times, wouldn't the cost for 10M tokens incur on DocsGPT?

@dartpain
Copy link
Contributor Author

dartpain commented Oct 1, 2024

Once user drags a file we should pop open the training modal to show progress.
In this case we can just preload that document into modal and wait till user clicks train

@sahil9001
Copy link
Contributor

Got it, I will raise a PR for this. Thanks!

@anurag-4508
Copy link

Is this issue still open? I want to work on it. Please assign me this task.
Thank you

@dartpain
Copy link
Contributor Author

dartpain commented Oct 4, 2024

@sahil9001

@sahil9001
Copy link
Contributor

hey @dartpain sorry i missed this, i am working on it.

@sahil9001
Copy link
Contributor

@dartpain Can you please clear this one last time? I mean the flow, it is —

  1. User picks a file.
  2. It auto uploads.
  3. Training modal opens up and file auto trains
  4. Finish

Is this correct?

@dartpain
Copy link
Contributor Author

dartpain commented Oct 7, 2024

Think we decided to change it a bit based on you comments.

  1. Users drops file into the input box
  2. Upload box open, not training yet, just preloaded the document
    CleanShot 2024-10-07 at 11 21 57@2x

@ManishMadan2882
Copy link
Collaborator

@sahil9001 is there any update?

@sahil9001
Copy link
Contributor

No, you can take it up if you want to, occupied with other work

@ManishMadan2882
Copy link
Collaborator

@anurag-4508

@Srayash
Copy link
Contributor

Srayash commented Oct 23, 2024

@ManishMadan2882 what is meant by input box here the textarea or the upload file from device?

@ManishMadan2882
Copy link
Collaborator

ManishMadan2882 commented Oct 23, 2024

Hi @tenokami,
We are planning to have a feature such that we hover a file over the input box in the Conversations, and the file drop modal pops up, can you please make it more clear in terms of UX.

@tenokami
Copy link
Collaborator

Hi @tenokami, We are planning to have a feature such that we hover a file over the input box in the Conversations, and the file drop modal pops up, can you please make it more clear in terms of UX.

I'm working on design for this and will send you

@AkashJana18
Copy link
Contributor

Hey @ManishMadan2882 @tenokami
I would like to work on this issue can you please assign it to me please.
Thank you.

@Srayash
Copy link
Contributor

Srayash commented Oct 28, 2024

hey @AkashJana18 I'm working on this issue, expect a PR soon.

@dartpain
Copy link
Contributor Author

Hey @Srayash Is is still active?

@Srayash
Copy link
Contributor

Srayash commented Nov 21, 2024

Yes, had my end semester exams going on.
Will be working on it soon.

@Srayash
Copy link
Contributor

Srayash commented Nov 27, 2024

I have set up the dropzone on the conversation bubble currently, onDrop logs the dropped files to the console.(#1459 )
I'll need help with the onDrop function to upload and turn the modal state to active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed javascript Pull requests that update Javascript code
Projects
None yet
7 participants