Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: drag and train functionality. #1459

Closed
wants to merge 4 commits into from

Conversation

Srayash
Copy link
Contributor

@Srayash Srayash commented Nov 27, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature: drag and train functionality.
  • Why was this change needed? (You can also link to an open issue here)
    fixes Drag and drop training, from input box #1167

Copy link

vercel bot commented Nov 27, 2024

@Srayash is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.96%. Comparing base (0a97e5b) to head (b58759d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1459   +/-   ##
=======================================
  Coverage   35.96%   35.96%           
=======================================
  Files          68       68           
  Lines        3275     3275           
=======================================
  Hits         1178     1178           
  Misses       2097     2097           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Srayash
Copy link
Contributor Author

Srayash commented Nov 29, 2024

@ManishMadan2882 Currently, this logs the dropped file to the console, gotta add the upload functionality but I'm stuck as the conversation and upload are 2 different components. maybe a new redux slice has to be implemented.

@ManishMadan2882
Copy link
Collaborator

Hi @Srayash
Think we can do it in this way, by importing the Upload component in the conversation.tsx
Certain changes will be required in the Upload component, where the activeTab is by default null we can maybe make a prop of the activeTab's default value lets say "file" for our use case.
But still the issues might arise when passing files as prop from the conversation component, because the states are already set as the component gets mounted, so better conditionally render the component when modalState === 'ACTIVE'

@Srayash
Copy link
Contributor Author

Srayash commented Dec 1, 2024

Some tests are failing after I merged main into this branch, will close this for now and raise a new PR.
thank you.

@Srayash Srayash closed this Dec 1, 2024
@Srayash Srayash deleted the Srayash/Drag branch December 1, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag and drop training, from input box
2 participants