Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wrapper modal #1434

Merged
merged 2 commits into from
Nov 20, 2024
Merged

feat: wrapper modal #1434

merged 2 commits into from
Nov 20, 2024

Conversation

rohittcodes
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    this pr introduces a wrapper modal, which will act as a base for every other modals. includes functionality to close the modal on a click outside the modal or an ESC key press.

  • Why was this change needed? (You can also link to an open issue here)
    fixes: 🚀 Feature: Modals under one style #1231

  • Other information:

Copy link

vercel bot commented Nov 12, 2024

@rohittcodes is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.89%. Comparing base (70f44fc) to head (04959df).
Report is 62 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1434      +/-   ##
==========================================
- Coverage   34.02%   33.89%   -0.13%     
==========================================
  Files          69       70       +1     
  Lines        3377     3440      +63     
==========================================
+ Hits         1149     1166      +17     
- Misses       2228     2274      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2024 11:22pm

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rohittcodes
Looks good, requesting one minor change to let the train button disabled for remote uploads as well, when the link field is empty
image

@rohittcodes
Copy link
Contributor Author

rohittcodes commented Nov 16, 2024

@ManishMadan2882 should I try adding something to prevent the modal from closing while training and upload?

@ManishMadan2882
Copy link
Collaborator

@rohittcodes Yes, we should avoid closing of the modal while upload/train is in process, good catch!

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rohittcodes !

@dartpain dartpain merged commit 9247f16 into arc53:main Nov 20, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Modals under one style
3 participants