-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wrapper modal #1434
feat: wrapper modal #1434
Conversation
@rohittcodes is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1434 +/- ##
==========================================
- Coverage 34.02% 33.89% -0.13%
==========================================
Files 69 70 +1
Lines 3377 3440 +63
==========================================
+ Hits 1149 1166 +17
- Misses 2228 2274 +46 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rohittcodes
Looks good, requesting one minor change to let the train button disabled for remote uploads as well, when the link field is empty
@ManishMadan2882 should I try adding something to prevent the modal from closing while training and upload? |
@rohittcodes Yes, we should avoid closing of the modal while upload/train is in process, good catch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @rohittcodes !
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
this pr introduces a wrapper modal, which will act as a base for every other modals. includes functionality to close the modal on a click outside the modal or an
ESC
key press.Why was this change needed? (You can also link to an open issue here)
fixes: 🚀 Feature: Modals under one style #1231
Other information: