Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Styling & Add search feature to backend #1442

Merged
merged 10 commits into from
Nov 26, 2024

Conversation

fadingNA
Copy link
Contributor

@fadingNA fadingNA commented Nov 16, 2024

@ManishMadan2882

Screenshot 2024-11-15 at 11 17 28 PM

Copy link

vercel bot commented Nov 16, 2024

@fadingNA is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 35.96%. Comparing base (144ab61) to head (d89bd09).
Report is 77 commits behind head on main.

Files with missing lines Patch % Lines
application/api/user/routes.py 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1442      +/-   ##
==========================================
+ Coverage   33.89%   35.96%   +2.07%     
==========================================
  Files          70       68       -2     
  Lines        3440     3275     -165     
==========================================
+ Hits         1166     1178      +12     
+ Misses       2274     2097     -177     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the application Application label Nov 18, 2024
@fadingNA fadingNA changed the title update table styling Table Styling & Add search feature to backend Nov 18, 2024
Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 8:07pm

@fadingNA
Copy link
Contributor Author

@ManishMadan2882 update table

…own rows per page select | adjust sync button
@fadingNA
Copy link
Contributor Author

@ManishMadan2882 please review have change and fix bug on sort order, and use effect behavior

@fadingNA
Copy link
Contributor Author

@ManishMadan2882 update white color on darkmode when no data and api.

align table using same format both apikey , document

@ManishMadan2882
Copy link
Collaborator

@fadingNA The settings/documents is scrollable even when it is not required(basically there is empty space below).
Ideally this shouldn't be there,
Could you please check.
Thanks!

@fadingNA
Copy link
Contributor Author

@ManishMadan2882 let me check

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thank you @fadingNA !

@fadingNA
Copy link
Contributor Author

LGTM, Thank you @fadingNA !

Appreciate it @ManishMadan2882 @dartpain

@dartpain dartpain merged commit 0584c29 into arc53:main Nov 26, 2024
7 of 8 checks passed
@fadingNA fadingNA deleted the document-table branch November 26, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants