Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add "Settings" Button to sidebar #691

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

SoumyadiptoPal
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature: Add "Settings" Button to sidebar
  • Why was this change needed? (You can also link to an open issue here)
    solves issue 🚀 Feature: Add "Settings" Button to sidebar #664
  • Other information:
Settings_DOCSGPT.mp4

image

@vercel
Copy link

vercel bot commented Oct 25, 2023

@SoumyadiptoPal is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ❌ Failed (Inspect) Oct 31, 2023 6:19pm
nextra-docsgpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 6:19pm

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #691 (6fc31dd) into main (4c6b8b4) will not change coverage.
Report is 8 commits behind head on main.
The diff coverage is n/a.

❗ Current head 6fc31dd differs from pull request most recent head f052c70. Consider uploading reports for the commit f052c70 to get more accurate results

@@           Coverage Diff           @@
##             main     #691   +/-   ##
=======================================
  Coverage   19.69%   19.69%           
=======================================
  Files          62       62           
  Lines        2844     2844           
=======================================
  Hits          560      560           
  Misses       2284     2284           

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SoumyadiptoPal
Copy link
Contributor Author

@dartpain please review this pull request

@tenokami
Copy link
Collaborator

tenokami commented Oct 29, 2023

@SoumyadiptoPal

  1. image

  2. Inactive tabs in light theme should have this font color like in figma: 747474, and on hover only text font color changes to: 7D54D1
    image

image

Should be like in figma:

image

https://www.figma.com/file/OXLtrl1EAy885to6S69554/DocsGPT?type=design&node-id=0%3A1&mode=design&t=T4nxPNHoRqKVSe7a-1

  1. I'd prefer if the gear icon for settings matched the one in figma
    image

  2. On mobile screens, let's not use horizontal scroll bar. And instead make the same way it is on YouTube
    image

i've placed arrors next to the frame in figma
image
image

@SoumyadiptoPal
Copy link
Contributor Author

SoumyadiptoPal commented Oct 30, 2023

@tenokami @dartpain can you please review and kindly merge this PR as today is the last day of hacktoberfeast. I will open separate issue to address the minute changes if required.
image
image

@tenokami
Copy link
Collaborator

tenokami commented Oct 30, 2023

@SoumyadiptoPal Thank you

@dartpain WIll merge it shortly.

I'm gonna make a separate issue with some adjustments

@tenokami
Copy link
Collaborator

@SoumyadiptoPal #740

@SoumyadiptoPal
Copy link
Contributor Author

@SoumyadiptoPal #740

Thank you sir. I will start working on the new issue😊

@SoumyadiptoPal
Copy link
Contributor Author

@dartpain please merge🫠🫠

@dartpain
Copy link
Contributor

Thank you so much!
Btw all PR that have been created before and including 31st count towords contributions by hacktoberfest even if merged 7 days after

@dartpain dartpain merged commit 64477c6 into arc53:main Oct 31, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants