-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add Search Bar to Navigation Component #705
Conversation
@adarsh-jha-dev is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #705 +/- ##
=======================================
Coverage 19.69% 19.69%
=======================================
Files 62 62
Lines 2844 2844
=======================================
Hits 560 560
Misses 2284 2284 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Thank you so much.
src/Navigation.tsx(173,33): error TS18047: 'conversations' is possibly 'null'.Error: Command "npm run build" exited with 2 |
I have tried to resolve that build error, could you please check that if the error is still there? |
Thank you, looks like its working, but desing wise its just on top of the page @tenokami maybe we can put search on top of the sidebar or something? how should we make it look? |
Thanks for considering, that was the problem i was unable to provide you the screenshot, i was worrying about the same, how should i make it look. |
There is an update available please sync with the latest version and checkout the design here to see how to integrate search |
It failed to build, src/Navigation.tsx(260,11): error TS2657: JSX expressions must have one parent element.Error: Command "npm run build" exited with 2 |
@alex , Really sorry for that build error, I will correct each and every
build error as well as make that front-end design by evening. Thank you.
…On Tue, Oct 31, 2023, 06:44 Alex ***@***.***> wrote:
It failed to build,
here is the error trace
src/Navigation.tsx(260,11): error TS2657: JSX expressions must have one
parent element.
Error: Command "npm run build" exited with 2
—
Reply to this email directly, view it on GitHub
<#705 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A7RVAC4SEIEFXWATDGGOMSTYCBGGFAVCNFSM6AAAAAA6QO57NWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBWGI4DCMZQG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hey @dartpain , I have made some changes , let me know if they are relevant or they need some modifications (i guess it should work now) |
@dartpain , I have done some changes , let me know if the search is placed correctly now |
Also there are some left overs here: Please try to stick to the design as mentioned here Also it works as it is supposed to so functionality wise its good, its just the appearance |
To be honest , I am a bit weak in styling, that is why I am making so much of errors, thanks for co-operating. Will do it ASAP |
You have this error src/Navigation.tsx(182,11): error TS17014: JSX fragment has no corresponding closing tag. Error: Command "npm run build" exited with 2 |
You have this error here src/Navigation.tsx(182,11): error TS17014: JSX fragment has no corresponding closing tag.12:45:28.710 | src/Navigation.tsx(192,15): error TS1005: '}' expected. Thank you, Does it work locally for you? |
Really sorry, wasn't working on it due to college exams, working on it now |
No worries, I just saw some commits and wanted to give some guidance. |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR introduces a new feature to the Navigation component, adding a search bar that allows users to search for and filter conversations based on their names.
Why was this change needed? (You can also link to an open issue here)
The addition of a search bar was needed to improve the user experience and make it easier for users to find specific conversations within the Navigation component.
Other information:
The search bar allows users to enter search queries and filters conversations accordingly.
Conversations are now dynamically filtered based on the search query.
The feature enhances usability, especially in cases where users have a large number of conversations.