Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Search Bar to Navigation Component #705

Closed
wants to merge 18 commits into from

Conversation

adarsh-jha-dev
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    This PR introduces a new feature to the Navigation component, adding a search bar that allows users to search for and filter conversations based on their names.

  • Why was this change needed? (You can also link to an open issue here)
    The addition of a search bar was needed to improve the user experience and make it easier for users to find specific conversations within the Navigation component.

  • Other information:

  • The search bar allows users to enter search queries and filters conversations accordingly.

  • Conversations are now dynamically filtered based on the search query.

  • The feature enhances usability, especially in cases where users have a large number of conversations.

@vercel
Copy link

vercel bot commented Oct 26, 2023

@adarsh-jha-dev is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ❌ Failed (Inspect) Nov 3, 2023 2:45pm
nextra-docsgpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 2:45pm

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.69%. Comparing base (2d20208) to head (39d029f).
Report is 1408 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #705   +/-   ##
=======================================
  Coverage   19.69%   19.69%           
=======================================
  Files          62       62           
  Lines        2844     2844           
=======================================
  Hits          560      560           
  Misses       2284     2284           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@adarsh-jha-dev adarsh-jha-dev changed the title feat: Add Search Bar to Navigation Component Feature: Add Search Bar to Navigation Component Oct 26, 2023
@dartpain
Copy link
Contributor

Thank you so much.
Just two things:

  1. Can you send the screenshot so we can check how it looks
  2. There is a build error

src/Navigation.tsx(173,33): error TS18047: 'conversations' is possibly 'null'.

Error: Command "npm run build" exited with 2

@adarsh-jha-dev
Copy link
Contributor Author

Thank you so much. Just two things:

  1. Can you send the screenshot so we can check how it looks
  2. There is a build error

src/Navigation.tsx(173,33): error TS18047: 'conversations' is possibly 'null'.

Error: Command "npm run build" exited with 2

I have tried to resolve that build error, could you please check that if the error is still there?

@dartpain
Copy link
Contributor

Thank you, looks like its working, but desing wise its just on top of the page
Screenshot 2023-10-26 at 14 22 17

@tenokami maybe we can put search on top of the sidebar or something? how should we make it look?

@adarsh-jha-dev
Copy link
Contributor Author

Thank you, looks like its working, but desing wise its just on top of the page Screenshot 2023-10-26 at 14 22 17

@tenokami maybe we can put search on top of the sidebar or something? how should we make it look?

Thanks for considering, that was the problem i was unable to provide you the screenshot, i was worrying about the same, how should i make it look.

@dartpain
Copy link
Contributor

There is an update available please sync with the latest version and checkout the design here to see how to integrate search
https://www.figma.com/file/OXLtrl1EAy885to6S69554/DocsGPT?type=design&node-id=0-1&mode=design

eg
Screenshot 2023-10-31 at 00 43 01
Thank you!

@dartpain
Copy link
Contributor

It failed to build,
here is the error trace

src/Navigation.tsx(260,11): error TS2657: JSX expressions must have one parent element.

Error: Command "npm run build" exited with 2

@adarsh-jha-dev
Copy link
Contributor Author

adarsh-jha-dev commented Oct 31, 2023 via email

@adarsh-jha-dev
Copy link
Contributor Author

Hey @dartpain , I have made some changes , let me know if they are relevant or they need some modifications (i guess it should work now)

@adarsh-jha-dev
Copy link
Contributor Author

adarsh-jha-dev commented Nov 1, 2023

@dartpain , I have done some changes , let me know if the search is placed correctly now

@dartpain
Copy link
Contributor

dartpain commented Nov 1, 2023

This is the way it looks now
Screenshot 2023-11-01 at 12 07 57

Also there are some left overs here:
Screenshot 2023-11-01 at 12 08 03

Please try to stick to the design as mentioned here
#705 (comment)

Also it works as it is supposed to so functionality wise its good, its just the appearance

@adarsh-jha-dev
Copy link
Contributor Author

This is the way it looks now Screenshot 2023-11-01 at 12 07 57

Also there are some left overs here: Screenshot 2023-11-01 at 12 08 03

Please try to stick to the design as mentioned here #705 (comment)

Also it works as it is supposed to so functionality wise its good, its just the appearance

To be honest , I am a bit weak in styling, that is why I am making so much of errors, thanks for co-operating. Will do it ASAP

@dartpain
Copy link
Contributor

dartpain commented Nov 2, 2023

You have this error

src/Navigation.tsx(182,11): error TS17014: JSX fragment has no corresponding closing tag.
src/Navigation.tsx(218,8): error TS1381: Unexpected token. Did you mean {'}'} or }?
src/Navigation.tsx(474,7): error TS1003: Identifier expected.
src/Navigation.tsx(475,4): error TS1005: '}' expected.
src/Navigation.tsx(476,1): error TS1381: Unexpected token. Did you mean {'}'} or }?
src/Navigation.tsx(477,1): error TS1005: '</' expected.
Error: Command "npm run build" exited with 2

Error: Command "npm run build" exited with 2

@dartpain
Copy link
Contributor

dartpain commented Nov 3, 2023

You have this error here

src/Navigation.tsx(182,11): error TS17014: JSX fragment has no corresponding closing tag.

12:45:28.710 | src/Navigation.tsx(192,15): error TS1005: '}' expected.
12:45:28.710 | src/Navigation.tsx(218,8): error TS1381: Unexpected token. Did you mean {'}'} or &rbrace;?
12:45:28.710 | src/Navigation.tsx(476,7): error TS1003: Identifier expected.
12:45:28.710 | src/Navigation.tsx(477,4): error TS1005: '}' expected.
12:45:28.710 | src/Navigation.tsx(478,1): error TS1381: Unexpected token. Did you mean {'}'} or &rbrace;?
12:45:28.711 | src/Navigation.tsx(479,1): error TS1005: '</' expected.
12:45:28.731 | Error: Command "npm run build" exited with 2

Thank you,

Does it work locally for you?

@adarsh-jha-dev
Copy link
Contributor Author

adarsh-jha-dev commented Nov 3, 2023

You have this error here

src/Navigation.tsx(182,11): error TS17014: JSX fragment has no corresponding closing tag.

12:45:28.710 | src/Navigation.tsx(192,15): error TS1005: '}' expected. 12:45:28.710 | src/Navigation.tsx(218,8): error TS1381: Unexpected token. Did you mean {'}'} or &rbrace;? 12:45:28.710 | src/Navigation.tsx(476,7): error TS1003: Identifier expected. 12:45:28.710 | src/Navigation.tsx(477,4): error TS1005: '}' expected. 12:45:28.710 | src/Navigation.tsx(478,1): error TS1381: Unexpected token. Did you mean {'}'} or &rbrace;? 12:45:28.711 | src/Navigation.tsx(479,1): error TS1005: '</' expected. 12:45:28.731 | Error: Command "npm run build" exited with 2

Thank you,

Does it work locally for you?

Really sorry, wasn't working on it due to college exams, working on it now

@dartpain
Copy link
Contributor

dartpain commented Nov 3, 2023

No worries, I just saw some commits and wanted to give some guidance.
Take you time, good luck with the exams!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants