Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(README): markdown highlight Note section #775

Merged
merged 7 commits into from
Nov 15, 2023

Conversation

guspan-tanadi
Copy link
Contributor

@guspan-tanadi guspan-tanadi commented Nov 13, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Highlight Note section by markdown formatting.
  • Why was this change needed? (You can also link to an open issue here)
    The Note section can have markdown as introduced by community. The display of Note section lightly marked by audience.
  • Other information:

Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 11:35pm
nextra-docsgpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 11:35pm

Copy link

vercel bot commented Nov 13, 2023

@guspan-tanadi is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c785e4) 19.69% compared to head (69d40b5) 19.69%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #775   +/-   ##
=======================================
  Coverage   19.69%   19.69%           
=======================================
  Files          62       62           
  Lines        2889     2889           
=======================================
  Hits          569      569           
  Misses       2320     2320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the docs label Nov 13, 2023
@guspan-tanadi guspan-tanadi marked this pull request as ready for review November 13, 2023 13:07
@guspan-tanadi guspan-tanadi changed the title style: markdown hightlight Note section README Quickstart style(README): markdown highlight Note section Nov 13, 2023
@dartpain
Copy link
Contributor

Can you please share some screenshots of how it will looks like,
Looks like a great addition!

@guspan-tanadi
Copy link
Contributor Author

guspan-tanadi commented Nov 14, 2023

Can you please share some screenshots of how it will looks like, Looks like a great addition!

Screenshot from 2023-11-15 06-36-38

Thanks for your interest. Example as part of QuickStart section shown as above.

@dartpain
Copy link
Contributor

Thank you!

@dartpain dartpain merged commit c14a9a5 into arc53:main Nov 15, 2023
9 of 10 checks passed
@guspan-tanadi guspan-tanadi deleted the markdownhighlightNote branch November 15, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants