Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message bubble responsiveness #841

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Message bubble responsiveness #841

merged 4 commits into from
Jan 29, 2024

Conversation

ManishMadan2882
Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 commented Jan 25, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Fixes - responsiveness for Mobile and Tablet Screens
  • Fixes - Like, Dislike, Copy buttons overlapped sources
  • Refactored - Wrapped the Three buttons(Copy, 👍🏼,👎🏻) in a single Div
  • Fixes Code overflow - Added Specific Max-Widths for Message Markdown large:
    • Large :50 vw
    • Medium 70vw
    • Small: 90vw (default)
  • Why was this change needed? (You can also link to an open issue here)
    UI enhancement, fixes, responsive behaviour

Demo

  • These 3 buttons come after the Markdown text in Mobile/Tablets
    Screenshot from 2024-01-26 02-36-18
  • Fixed Overflow for Large Texts (especially the ones including code)
    Screenshot from 2024-01-26 02-06-19

@ManishMadan2882 ManishMadan2882 added bug Something isn't working enhancement New feature or request labels Jan 25, 2024
Copy link

vercel bot commented Jan 25, 2024

@ManishMadan2882 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e3886c) 19.11% compared to head (6058939) 19.11%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #841   +/-   ##
=======================================
  Coverage   19.11%   19.11%           
=======================================
  Files          65       65           
  Lines        3013     3013           
=======================================
  Hits          576      576           
  Misses       2437     2437           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dartpain
Copy link
Contributor

Amazing job @ManishMadan2882
I think it would look better if we put the Three buttons(Copy, 👍🏼,👎🏻) on top

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 1:43pm

@dartpain dartpain merged commit a697248 into arc53:main Jan 29, 2024
9 checks passed
@dartpain
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants