CMake : add support for RLM protection #1780
Draft
+111
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 6, 2024 09:36
export ARCANE_CONFIG_ENABLED_PACKAGES="FLEXLM" cmake -DPROTECTION=RLM .. Default value for Protection is FLEXLM.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1780 +/- ##
==========================================
+ Coverage 70.15% 70.26% +0.10%
==========================================
Files 2256 2258 +2
Lines 161018 162285 +1267
Branches 18571 18694 +123
==========================================
+ Hits 112969 114036 +1067
- Misses 41328 41479 +151
- Partials 6721 6770 +49 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
cedricga91
changed the title
|
@stdcm : si tu as des remarques, n'hésite pas. |
stdcm
reviewed
Nov 29, 2024
| # - arcane/src/arcane/impl/FlexLMTools.h | ||
| # - arcane/src/arcane/impl/FlexLMTools.cc | ||
| if("${FLEXLM_PROTECTION_NAME}" STREQUAL "RLM") | ||
| ADD_DEFINITIONS(-DARCANE_TEST_RLM) |
There was a problem hiding this comment.
il faudrait déplacer cet ajout de définition dans le cmake de arcane_impl : arcane/src/arcane/impl/CMakeLists.txt et écrire plutôt, dans la section if (FLEXLM_FOUND) avec un target_compile_definition :
target_compile_definition(arcane_impl PUBLIC ARCANE_TEST_RLM)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
La procédure d'installation avec la protection FlexLM ne change pas.
Pour réaliser l'installation avec la protection RLM, il faut charger le module
RLM_LIcenseAPI(qui fournit la variableRLM_ROOT) à la place du module FlexLM et ajouter l'option-DPROTECTION=RLMà la commandecmake.On garde
FLEXLMcomme nom de paquet pour ne pas casser la compatibilité avec les applications déjà existantes basées sur le framework Arcane.A noter que la défintion
ARCANE_TEST_RLMdevra être supprimée des fichiers suivants le moment voulu :arcane/CMakeLists.txtarcane/src/arcane/impl/FlexLMTools.ccarcane/src/arcane/impl/FlexLMTools.h