Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/v1/models - format output to match OpenAI styling #34

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

aricshow
Copy link
Contributor

@aricshow aricshow commented Oct 2, 2024

Adjust /v1/models endpoint so that its output matches the styling of OpenAI's API /v1/models endpoint.
Adjust README.md to state this change, as well as minor edits for clarity between different functions.

@Blaizzy
Copy link
Collaborator

Blaizzy commented Oct 2, 2024

@aricshow great job! 🔥

@Blaizzy
Copy link
Collaborator

Blaizzy commented Oct 2, 2024

Some style checks are failing.

Can you run pre-commit ?

After the tests clear we can merge.

@aricshow
Copy link
Contributor Author

aricshow commented Oct 3, 2024

@Blaizzy Oof, sorry, ran and cleared!

@Blaizzy
Copy link
Collaborator

Blaizzy commented Oct 3, 2024

Could you fix the tests to support your changes

@Blaizzy Blaizzy merged commit c7f48ba into arcee-ai:main Oct 29, 2024
1 of 2 checks passed
@Blaizzy Blaizzy mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants