Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] replace deprecated sbi_rt legacy console operations in riscv #195

Merged
merged 6 commits into from
Oct 29, 2024

Conversation

hky1999
Copy link
Contributor

@hky1999 hky1999 commented Oct 24, 2024

@hky1999 hky1999 changed the title [feat] replace deprecated sbi_rt legacy console operations in riscv p… [feat] replace deprecated sbi_rt legacy console operations in riscv Oct 24, 2024
Copy link

@luojia65 luojia65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If possible, should we test the kernel with this patch on various SBI implementations?

@hky1999
Copy link
Contributor Author

hky1999 commented Oct 28, 2024

LGTM. If possible, should we test the kernel with this patch on various SBI implementations?

Thanks for your approval, as a matter of fact, it seems to failed to output anything on qemu 7.1.0

@luojia65
Copy link

@hky1999: Does the built-in firmware in QEMU 7.1.0 support SBI 2.0 DBCN extension? If possible, we can use newer QEMU version, or other versions of any SBI firmware.

@hky1999
Copy link
Contributor Author

hky1999 commented Oct 29, 2024

Does the built-in firmware in QEMU 7.1.0 support SBI 2.0 DBCN extension?

@luojia65 I'm not familiar with that, how can I check that?

If possible, we can use newer QEMU version, or other versions of any SBI firmware.

sure, qemu of version 9.0.0 and 8.2.0 all work fine.

@hky1999 hky1999 merged commit cfe25df into main Oct 29, 2024
26 checks passed
@luojia65
Copy link

Does the built-in firmware in QEMU 7.1.0 support SBI 2.0 DBCN extension?

@luojia65 I'm not familiar with that, how can I check that?

@hky1999 We can use sbi_rt::probe_extension feature to check if DBCN presents; if it returned 0, it means that this extension is available.

@hky1999
Copy link
Contributor Author

hky1999 commented Oct 29, 2024

Does the built-in firmware in QEMU 7.1.0 support SBI 2.0 DBCN extension?

@luojia65 I'm not familiar with that, how can I check that?

@hky1999 We can use sbi_rt::probe_extension feature to check if DBCN presents; if it returned 0, it means that this extension is available.

oh, i remembered, we use this api for the check of h-extension, ok we'll check it later

@PeizhongQiu
Copy link

Does the built-in firmware in QEMU 7.1.0 support SBI 2.0 DBCN extension?

@luojia65 I'm not familiar with that, how can I check that?

@hky1999 We can use sbi_rt::probe_extension feature to check if DBCN presents; if it returned 0, it means that this extension is available.

I checked it and found it returned 0

@hky1999
Copy link
Contributor Author

hky1999 commented Oct 29, 2024

Does the built-in firmware in QEMU 7.1.0 support SBI 2.0 DBCN extension?

@luojia65 I'm not familiar with that, how can I check that?

@hky1999 We can use sbi_rt::probe_extension feature to check if DBCN presents; if it returned 0, it means that this extension is available.

I checked it and found it returned 0

Do we need to consider compatibility design here, like rollback to legacy SBI when DBSN extension is not supported?
or it's just fine for us to stick on the latest SBI version here :)
@luojia65 @equation314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants