-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] replace deprecated sbi_rt legacy console operations in riscv #195
Conversation
4730324
to
4ad6a48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If possible, should we test the kernel with this patch on various SBI implementations?
Thanks for your approval, as a matter of fact, it seems to failed to output anything on qemu 7.1.0 |
@hky1999: Does the built-in firmware in QEMU 7.1.0 support SBI 2.0 DBCN extension? If possible, we can use newer QEMU version, or other versions of any SBI firmware. |
@luojia65 I'm not familiar with that, how can I check that?
sure, qemu of version 9.0.0 and 8.2.0 all work fine. |
oh, i remembered, we use this api for the check of h-extension, ok we'll check it later |
I checked it and found it returned 0 |
Do we need to consider compatibility design here, like rollback to legacy SBI when DBSN extension is not supported? |
found by arceos-hypervisor/riscv_vcpu#8
which caused https://github.com/arceos-hypervisor/arceos-umhv/actions/runs/11483702522/job/31959762361 to fail
console_putchar and console_getchar
are deprecated