Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "multilanguage support" and a brazilian portuguese translation #28

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

kyweehz
Copy link

@kyweehz kyweehz commented Apr 24, 2024

I've made minor adjustments to the pages to enable language selection in the navigation menu, added basic translation instructions to the readme, and included a complete Brazilian Portuguese translation.

@adi1090x
Copy link
Member

Hey @kyweehz

Interesting PR, But tested your fork locally and it's not working as expected.

It's messing up with design :
Screenshot_2024-05-13-11-33-36_1920x1080

And, clicking on Flags doesn't change to translated pages.
Screenshot_2024-05-13-11-33-53_1920x1080

How this suppose to work without JS?

@kyweehz
Copy link
Author

kyweehz commented May 13, 2024

The previous version only works as intended when accessed through a web server, but I made a few changes, and now it also works when opened from a local folder. Since the language menu only uses css and links, it will function normally even without javascript enabled. I also updated the pt-BR translation to keep up with the latest changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants