Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10 Add RDM->CLM CLI migration path #18

Merged
merged 11 commits into from
Aug 12, 2024

Conversation

johnatawnclementawn
Copy link
Member

Fixes pg function to point to correct controlled list tables & columns.
Adds CLI tool for utilizing that pg function to migration collections to lists.

Name of commands/controlled_lists.py is still up for debate.

jacobtylerwalls added a commit that referenced this pull request Jul 31, 2024
@jacobtylerwalls jacobtylerwalls self-assigned this Aug 8, 2024
@jacobtylerwalls jacobtylerwalls self-requested a review August 8, 2024 17:54
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some minor feedback at your option.

tests/data/concept_label_test_collection.xml Outdated Show resolved Hide resolved
tests/cli_tests.py Outdated Show resolved Hide resolved
tests/cli_tests.py Outdated Show resolved Hide resolved
tests/cli_tests.py Show resolved Hide resolved
tests/cli_tests.py Outdated Show resolved Hide resolved
tests/cli_tests.py Outdated Show resolved Hide resolved
tests/cli_tests.py Show resolved Hide resolved
arches_references/management/commands/controlled_lists.py Outdated Show resolved Hide resolved
arches_references/management/commands/controlled_lists.py Outdated Show resolved Hide resolved
cursor = connection.cursor()
cursor.execute(
"""
select * from __arches_migrate_collections_to_clm(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. In the future we can consider implementing the Func expressions API to be able to use custom db functions with the ORM.

@jacobtylerwalls jacobtylerwalls merged commit c3049b7 into main Aug 12, 2024
6 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jmc/10_add_rdm_to_clm_migrator_cli branch August 12, 2024 16:59
@johnatawnclementawn
Copy link
Member Author

Thanks for the review @jacobtylerwalls 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[controlled-lists] Implement CLI interface for RDM -> CLM ETL
2 participants