Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve RDM to CLM migration #23 #26

Merged
merged 28 commits into from
Sep 12, 2024
Merged

Improve RDM to CLM migration #23 #26

merged 28 commits into from
Sep 12, 2024

Conversation

johnatawnclementawn
Copy link
Member

@johnatawnclementawn johnatawnclementawn commented Aug 22, 2024 •
edited
Loading

Resolves #23

@johnatawnclementawn
Avoid trying to create list items that dont belong in hierarchy when …
ab25446 
…concepts belong to many collections #23
@johnatawnclementawn
clarification
a834ac0
@johnatawnclementawn
Reduce queries to existing RDM tables, use temp tbl to gather records…
97c31c2 
… being created #23
@johnatawnclementawn
Improve filter on which tree is being built for concepts in multiple …
cc7a569 
…collections #23
@johnatawnclementawn
Mint new item and itemvalue ids for concepts that participate in mult…
552b9ca 
…iple collections #23
@johnatawnclementawn
Add descriptions for new logic #23
1eecf83
@johnatawnclementawn
Check for listitems that already exist in CLM, but participate in col…
3e5203b 
…lection being migrated #23
@johnatawnclementawn
Add note about apostrophes in collection names
3ed8d95
@johnatawnclementawn
nit #23
1cd0ae4
@johnatawnclementawn
Simplify logic for minting new ids for items and values #23
d9486d7
@johnatawnclementawn
Merge branch 'main' into jmc/23_improve_rdm_to_clm_migration
2adc1bb
@johnatawnclementawn
Merge branch 'main' into jmc/23_improve_rdm_to_clm_migration
bf3b9d4
@johnatawnclementawn
Add note for how to handle apostrophes in collection names on python …
3e2821c 
…cmd side #23
@johnatawnclementawn johnatawnclementawn marked this pull request as ready for review August 29, 2024 19:41
jacobtylerwalls
jacobtylerwalls reviewed Sep 11, 2024
View reviewed changes
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. couple quick things I noticed

tests/cli_tests.py Outdated Show resolved Hide resolved
tests/data/polyhierarchical_collections.json Outdated Show resolved Hide resolved
jacobtylerwalls
jacobtylerwalls reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests looks great. Couple last items and should be g2g

tests/cli_tests.py Outdated Show resolved Hide resolved
tests/cli_tests.py Outdated Show resolved Hide resolved
tests/test_settings.py Outdated Show resolved Hide resolved
tests/cli_tests.py Show resolved Hide resolved
arches_references/management/commands/controlled_lists.py Show resolved Hide resolved
arches_references/migrations/0002_etl_collections_to_controlled_lists.py Outdated Show resolved Hide resolved
jacobtylerwalls
jacobtylerwalls approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest pushes look great! Happy to table to the little nit about rerunning the command.

@jacobtylerwalls jacobtylerwalls merged commit 032a84b into main Sep 12, 2024
5 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jmc/23_improve_rdm_to_clm_migration branch September 12, 2024 21:45
@johnatawnclementawn johnatawnclementawn restored the jmc/23_improve_rdm_to_clm_migration branch September 16, 2024 19:44
@johnatawnclementawn johnatawnclementawn deleted the jmc/23_improve_rdm_to_clm_migration branch September 16, 2024 19:45
@johnatawnclementawn johnatawnclementawn mentioned this pull request Sep 25, 2024
Merged
@johnatawnclementawn johnatawnclementawn mentioned this pull request Nov 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtylerwalls jacobtylerwalls jacobtylerwalls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collections to Controlled Lists migration chokes on concepts used in multiple collections
2 participants
@johnatawnclementawn @jacobtylerwalls