Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare template refs with useTemplateRef() #36

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Declare template refs with useTemplateRef() #36

merged 1 commit into from
Oct 1, 2024

Conversation

jacobtylerwalls
Copy link
Member

Use vue 3.5 syntax for declaring template refs.

Testing instructions

  • Visit the elements with this functionality (e.g. input boxes in the tree or datatables) and ensure they still receive focus when mounted.

@jacobtylerwalls
Copy link
Member Author

Tests expected to fail until archesproject/arches-vue-utils#1

johnatawnclementawn
johnatawnclementawn approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@johnatawnclementawn johnatawnclementawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - input boxes still receive focus

@jacobtylerwalls jacobtylerwalls changed the base branch from jtw/use-label-finder-util to main October 1, 2024 17:59
@jacobtylerwalls
Copy link
Member Author

Thanks for the review. Rebased on main so as not to clutter the diff on #32. (This was targeting #32 for ease of testing).

@jacobtylerwalls jacobtylerwalls merged commit 1dd0720 into main Oct 1, 2024
2 of 3 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/use-template-ref branch October 1, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnatawnclementawn johnatawnclementawn johnatawnclementawn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobtylerwalls @johnatawnclementawn