Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust github action template #47

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Adjust github action template #47

merged 1 commit into from
Nov 2, 2024

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Nov 1, 2024

Cope with changes to the github action template merged in archesproject/arches#10079.

Rationale

The github action only sets up a test db, not a real db. The system check in archesproject/arches#10079 expects there to be a real db, so we need to skip system checks in a couple places where we're not intending to run them. The first place is just there to generate the frontend config file.

Copy link
Contributor

@aarongundel aarongundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird to have --check and then --skip-checks, but I get it. Thanks for the context. LGTM.

@aarongundel aarongundel merged commit 946d014 into main Nov 2, 2024
4 of 5 checks passed
@aarongundel aarongundel deleted the jtw/fix-github-action branch November 2, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants