Improve javascript compatibility #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archfz
reviewed
Sep 1, 2024
wemcdonald
force-pushed
the
wemcdonald/es5-compatible
branch
from
9e6147f to
0ac5eee
Compare
|
@archfz Any idea on the failing test? |
|
It was a flake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's just one usage of the
?optional chaining operator in this package, which was introduced in ES2020.I have a large project in which I can't easily upgrade the webpack target ES version, and running master gives the error below.
This fix will make your awesome package available to more people. :)