Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: more constants, improved types #261

Merged
merged 27 commits into from
Nov 13, 2024

Conversation

bvandercar-vt
Copy link
Contributor

@bvandercar-vt bvandercar-vt commented Nov 5, 2024

  • remove many any types by actually specifying the correct type
  • add more constants to CONSTANTS
  • improve link between CONSTANTS and types

@archfz
Copy link
Owner

archfz commented Nov 13, 2024

This looks really good. Nice job.

@archfz
Copy link
Owner

archfz commented Nov 13, 2024

Should this be merged before the lint update? Thinking of conflicts.

@bvandercar-vt
Copy link
Contributor Author

bvandercar-vt commented Nov 13, 2024

This looks really good. Nice job.

Thank you! 😃

Should this be merged before the lint update? Thinking of conflicts.

Either one first is fine. Merge should be easy actually, I can pull from master and do it locally on the branch-- I'll just ignore all the Prettier code changes from that PR (since there are no actual functional code changes, literally just the output of the format script), then re-run the format script after that.

@archfz archfz merged commit 0b2956d into archfz:master Nov 13, 2024
2 checks passed
@bvandercar-vt bvandercar-vt deleted the bvandercar/more-constants branch November 14, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants