-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated minimum package lists for Cinnamon, Cutefish, Deepin, GNOME, I3, KDE Plasma, LXQt, Sway, GPU drivers and deleted Wayfire desktop profile #3069
base: master
Are you sure you want to change the base?
Conversation
archinstall/lib/hardware.py
Outdated
@@ -67,7 +61,7 @@ class GfxDriver(Enum): | |||
AmdOpenSource = 'AMD / ATI (open-source)' | |||
IntelOpenSource = 'Intel (open-source)' | |||
NvidiaOpenKernel = 'Nvidia (open kernel module for newer GPUs, Turing+)' | |||
NvidiaOpenSource = 'Nvidia (open-source nouveau driver)' | |||
NvidiaOpenSource = 'Nvidia (open-source Nouveau driver)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are breaking changes and it'd be better (even it's not perfect) to maybe leave them as they are. Any existing config will not be parsed correctly anymore as the naming won't match
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never thought that such a small change could break everything.
I apologize for my stupidity )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed it
@@ -44,19 +44,13 @@ def get_ucode(self) -> Path | None: | |||
|
|||
|
|||
class GfxPackage(Enum): | |||
Dkms = 'dkms' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you share why these packages were removed and what the reasoning is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dkms is a dependency of the nvidia-dkms and nvidia-open-dkms packages
@Metelar could you provide some description of the packages and why they would be relevant and good to have for a minimal installation. Some of them seem subjective such as |
I didn’t know that GNOME Files had a built-in archiver. |
"swayidle", | ||
"waybar", | ||
"dmenu", | ||
"wmenu", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this deprecated https://github.com/LinArcX/wmenu ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"foot", | ||
"xorg-xwayland" | ||
"xorg-xwayland", | ||
"xdg-desktop-portal-gtk", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this essential? Seems to me more of an optional thing to work with things like Flatpak https://wiki.archlinux.org/title/XDG_Desktop_Portal
"ark", | ||
"plasma-workspace" | ||
"bluedevil", | ||
"breeze-gtk", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breeze-gtk
nice to have for theme, not essentialplasma-nm
may not be wanted if the users did not setup any networking in the settingsplasma-pa
also depends on the configuration of the audio server installed and may not be wantedsddm-kcm
this should probably only be installed if SDDM was choosen as the greeter
OK, I removed these and also the bluedevil and kde-gtk-config packages |
Maybe it's time to merge this commit? ) |
Wayfire is currently only available in AUR )
"xdg-user-dirs-gtk" | ||
'cinnamon', | ||
'gvfs-mtp', | ||
'gnome-console' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was wrong with all the other packages? It would be great if you could actually provide references and a description for all these changes
@Metelar pushing new changes to this PR makes it more difficult to verify and review. There is no description of any of these changes nor reasoning for the packges added/removed, that doesn't mean it's bad changes but simply it's all unknowns that need to be verified carefully. These profiles are generally a sensitive topic among users with a lot of subjective opinions so the rules should be "Only install minimum packages to provide all basic working functionality for the profile" I need to verify all the GFX driver changes as there were quite a few issues in the past. |
@@ -13,8 +13,7 @@ def __init__(self) -> None: | |||
def packages(self) -> list[str]: | |||
return [ | |||
"deepin", | |||
"deepin-terminal", | |||
"deepin-editor" | |||
"deepin-terminal" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://wiki.archlinux.org/title/Deepin_Desktop_Environment
Install deepin and deepin-kwin for the basic components for a minimal desktop interface.
Optionally, also install deepin-extra for some extra applications for a more complete desktop environment.
@@ -12,8 +12,11 @@ def __init__(self) -> None: | |||
@override | |||
def packages(self) -> list[str]: | |||
return [ | |||
'gnome', | |||
'gnome-tweaks' | |||
'gnome-shell', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could potentially just install the gnome
group https://archlinux.org/groups/x86_64/gnome/ as recommneded https://wiki.archlinux.org/title/GNOME
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but there are many unnecessary packages in this group.
The 'gnome-shell' package is enough to run GNOME, but I also added a system settings app (gnome-control-center), a terminal emulator (gnome-console), a file manager (nautilus) and an additional GVFS package to transfer files on the MTP protocol [1]
@@ -12,14 +12,9 @@ def __init__(self) -> None: | |||
@override | |||
def packages(self) -> list[str]: | |||
return [ | |||
'alacritty', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also here settling with the group https://archlinux.org/groups/x86_64/i3/ would be good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but there are many unnecessary packages in this group.
from archinstall.default_profiles.xorg import XorgProfile | ||
|
||
|
||
class WayfireProfile(XorgProfile): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wayfire is currently not available in the official Arch Linux repositories, the author of the script has not implemented installation of this package from AUR
I don’t have an Nvidia video card to test the changes, but I think that by replacing the packages, the problems with Nvidia will not get any bigger or smaller |
No description provided.