Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade to Archway v6 #114

Merged
merged 4 commits into from
Feb 6, 2024
Merged

feat!: upgrade to Archway v6 #114

merged 4 commits into from
Feb 6, 2024

Conversation

eliasmpw
Copy link
Contributor

@eliasmpw eliasmpw commented Feb 6, 2024

Added

arch3-core

  • added withdrawToWallet property to the ContractMetadata interface

Changed

arch3-proto

  • updated to the version 6.0.0 of the protocol

@eliasmpw eliasmpw requested a review from aelesbao February 6, 2024 00:15
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

codacy-production bot commented Feb 6, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (87fcd20) 0 0 97.72%
Head commit (c238c82) 1148 (+1148) 1122 (+1122) 97.74% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#114) 8 8 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@eliasmpw eliasmpw requested a review from aelesbao February 6, 2024 09:09
Copy link
Member

@aelesbao aelesbao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eliasmpw eliasmpw merged commit 1ceca20 into main Feb 6, 2024
9 checks passed
@eliasmpw eliasmpw deleted the feature/archway-v6 branch February 6, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants