Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): workaround for batching issue in V9 #121

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

eliasmpw
Copy link
Contributor

There is an issue with the batch queries in Constantine (which is running protocol v9)

As a temporary workaround until finding the root cause of this issue, we can force the ArchwayClient to connect using Tendermint37Client

Copy link

codacy-production bot commented Sep 11, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.07% (target: -1.00%) 33.33%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (35ea42b) 1373 1313 95.63%
Head commit (e368eba) 1375 (+2) 1314 (+1) 95.56% (-0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#121) 6 2 33.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

macku99
macku99 previously approved these changes Sep 11, 2024
Copy link
Contributor

@macku99 macku99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macku99 macku99 merged commit 7143f60 into main Sep 11, 2024
9 checks passed
@macku99 macku99 deleted the fix/workaround-batch-issue branch September 11, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants