-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
epic: Embedded Wallet PoC #497
Draft
Danziger
wants to merge
22
commits into
development
Choose a base branch
from
epic/embedded-wallet
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danziger
changed the base branch from
development
to
feature/reorganize-wallet-installation-n-setup
November 25, 2024 09:03
Base automatically changed from
feature/reorganize-wallet-installation-n-setup
to
development
December 4, 2024 20:40
…t working on the mocked AuthenticationService (WIP).
…e-wallet, import-wallet and restore-shards flows. Creates some scaffolding for the account pages.
…ile for embedded (to be organized properly).
…r authentication, fix bug with alarms polyfill.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merge:
activeTab.url
Apps / Modules
Architecture Changes (Routing, Navigation, Messaging)
See Update most links to dashboard to open in quick-settings instead. #500
See Config-based routing,
wouter
v3
, customuseLocation()
/navigate()
#556browser.i18n
API.browser.*
calls (with lazy-loading per view?)./src/injected.ts
and/src/api/index.ts
with something similar to Othent. There, the “api” module should actually be a strategy, so that we can have a different one for the embedded wallet that sends “requests” to the iframe using postMessage().TODO (before extracting router changes to their own PR):
window.top.close()
inAuthRequestsProvider
.browser.storage.local.get()
withExtensionStorage.getAll()
.AuthHead
from pages in the Auth popup. Consider doing the same for the wallet. Consider implementing a generic "PageWrapper" with/without visible scrollbars.TODO (next):
onMessage
andsendMessage
withisomorphicOnMessage
andisomorphicSendMessage
(using the env variable). After this, there's probably no need to mockonConnect
.getDecryptionKey
as we won't be using this in the embedded wallet...useEmbeddedWalletSetUp()
to return aRedirect
object.browser.storage.onChanged.addListener(handleAppConfigChange)
cannot be replaced withExtensionStorage
and watchers won't work while on the same context / tab.// TODO: Record last alarm run in localStorage to continue the alarm when reloading...
)