This repository has been archived by the owner on Dec 1, 2023. It is now read-only.
Improve and simplify tf structure for ecs fargate #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldimious
suggested changes
Mar 19, 2022
| resource "aws_launch_template" "this" { | ||
| name_prefix = var.lauch_template_name | ||
| image_id = data.aws_ami.amazon_linux.id | ||
| instance_type = "t2.micro" |
There was a problem hiding this comment.
Perhaps we can move it to a variable with default value
| id = aws_launch_template.this.id | ||
| version = "$Latest" | ||
| } | ||
| desired_capacity = 4 |
There was a problem hiding this comment.
Perhaps we can move it to a variable with default value, same for the rest of props
|
|
||
| action { | ||
| type = var.alb_listener_rule_type # Redirect all traffic from the ALB to the target group | ||
| type = var.alb.listener.rule_type # Redirect all traffic from the ALB to the target group | ||
| target_group_arn = aws_alb_target_group.this[0].arn | ||
| } | ||
|
|
||
| condition { | ||
| path_pattern { |
There was a problem hiding this comment.
perhaps we can add it in a dynamic block
| Environment = var.environment | ||
| } | ||
|
|
||
| data "aws_availability_zones" "available" { |
There was a problem hiding this comment.
hm this way we fetch all aws_availability_zones right? If we want to deploy something only to 2 of 3 availability_zones ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.