Change Text style props to the correct type #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
doneButtonTitleStyle
andinfoMessageStyle
are style props toText
components, therefore their type should beStyleProp<TextStyle>
. This fixes a typescript bug that would disallow you from setting Text-specific styles on these properties likefontSize
andfontWeight
to name a few.Note
I noticed when going through the code that you added
infoContainer
,infoMessage
andinfoMessageStyle
, but only the latter is defined in the types. I tried these out and they seem to work as inteded, if you want I can add these props to the types and README so they are discoverable to future users.