-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear advertising data when BLE end is called #373
Merged
facchinm
merged 1 commit into
arduino-libraries:master
from
fabik111:fix-local-name-end
Oct 25, 2024
Merged
Clear advertising data when BLE end is called #373
facchinm
merged 1 commit into
arduino-libraries:master
from
fabik111:fix-local-name-end
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory usage change @ 910dd44
Click for full report table
Click for full report CSV
|
facchinm
approved these changes
Oct 25, 2024
Merged, thx! |
per1234
added
type: imperfection
Perceived defect in any part of project
topic: code
Related to content of the project itself
labels
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_advertisingData
and_scanResponseData
structure are never cleared even if the user call theBLE.end()
.If the user after a BLE.end() opens again the BLE.begin() and confgure local name, service, characteristic, etc. some of them are not set properly since the counters and the data pointers are full from the previous iteration.
With this PR the clear method of
_advertisingData
and_scanResponseData
is called inside theBLE.end()
method.