Cmake improvements

[andreagilardoni]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.39%. Comparing base (9166399) to head (b7a22f6).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #504   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files          33       33           
  Lines        1520     1520           
=======================================
  Hits         1450     1450           
  Misses         70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Memory usage change @ cbb014d

Board	flash	%	RAM for global variables	%
arduino:esp32:nano_nora	🔺 +12 - +12	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_edge:edge_control	🔺 0 - +64	0.0 - +0.01	0 - 0	0.0 - 0.0
arduino:mbed_giga:giga	🔺 0 - +64	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_nano:nanorp2040connect	🔺 0 - +14	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_nicla:nicla_vision	🔺 0 - +64	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_opta:opta	🔺 0 - +64	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_portenta:envie_m7	N/A	N/A	N/A	N/A
arduino:renesas_portenta:portenta_c33	🔺 0 - +16	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:renesas_uno:unor4wifi	🔺 +16 - +16	+0.01 - +0.01	0 - 0	0.0 - 0.0
arduino:samd:mkr1000	🔺 0 - +16	0.0 - +0.01	0 - 0	0.0 - 0.0
arduino:samd:mkrgsm1400	🔺 0 - +16	0.0 - +0.01	0 - 0	0.0 - 0.0
arduino:samd:mkrnb1500	🔺 0 - +16	0.0 - +0.01	0 - 0	0.0 - 0.0
arduino:samd:mkrwan1300	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	🔺 0 - +16	0.0 - +0.01	0 - 0	0.0 - 0.0
arduino:samd:nano_33_iot	🔺 0 - +16	0.0 - +0.01	0 - 0	0.0 - 0.0
esp32:esp32:esp32	🔺 +12 - +12	0.0 - 0.0	0 - 0	0.0 - 0.0
esp8266:esp8266:huzzah	🔺 +16 - +16	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/ArduinoIoTCloud-Advanced flash	%	examples/ArduinoIoTCloud-Advanced RAM for global variables	%	examples/ArduinoIoTCloud-Basic flash	%	examples/ArduinoIoTCloud-Basic RAM for global variables	%	examples/ArduinoIoTCloud-Callbacks flash	%	examples/ArduinoIoTCloud-Callbacks RAM for global variables	%	examples/ArduinoIoTCloud-Schedule flash	%	examples/ArduinoIoTCloud-Schedule RAM for global variables	%	examples/utility/ArduinoIoTCloud_Travis_CI flash	%	examples/utility/ArduinoIoTCloud_Travis_CI RAM for global variables	%	examples/ArduinoIoTCloud-DeferredOTA flash	%	examples/ArduinoIoTCloud-DeferredOTA RAM for global variables	%	examples/utility/Provisioning flash	%	examples/utility/Provisioning RAM for global variables	%	examples/utility/SelfProvisioning flash	%	examples/utility/SelfProvisioning RAM for global variables	%
arduino:esp32:nano_nora	12	0.0	0	0.0	12	0.0	0	0.0	12	0.0	0	0.0	12	0.0	0	0.0	12	0.0	0	0.0	12	0.0	0	0.0
arduino:mbed_edge:edge_control	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	64	0.01	0	0.0
arduino:mbed_giga:giga	0	0.0	0	0.0	64	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	64	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed_nano:nanorp2040connect	14	0.0	0	0.0	14	0.0	0	0.0	14	0.0	0	0.0	14	0.0	0	0.0	14	0.0	0	0.0	14	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed_nicla:nicla_vision	0	0.0	0	0.0	0	0.0	0	0.0	64	0.0	0	0.0	64	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed_opta:opta	0	0.0	0	0.0	0	0.0	0	0.0	64	0.0	0	0.0	64	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed_portenta:envie_m7	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A
arduino:renesas_portenta:portenta_c33	16	0.0	0	0.0	16	0.0	0	0.0	16	0.0	0	0.0	16	0.0	0	0.0	16	0.0	0	0.0					0	0.0	0	0.0
arduino:renesas_uno:unor4wifi	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0
arduino:samd:mkr1000	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0					0	0.0	0	0.0
arduino:samd:mkrgsm1400	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0					0	0.0	0	0.0
arduino:samd:mkrnb1500	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0					0	0.0	0	0.0
arduino:samd:mkrwan1300	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrwifi1010	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:nano_33_iot	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
esp32:esp32:esp32	12	0.0	0	0.0	12	0.0	0	0.0	12	0.0	0	0.0	12	0.0	0	0.0	12	0.0	0	0.0	12	0.0	0	0.0
esp8266:esp8266:huzzah	16	0.0	0	0.0	16	0.0	0	0.0	16	0.0	0	0.0	16	0.0	0	0.0	16	0.0	0	0.0

Click for full report CSV

Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/ArduinoIoTCloud-Callbacks<br>flash,%,examples/ArduinoIoTCloud-Callbacks<br>RAM for global variables,%,examples/ArduinoIoTCloud-Schedule<br>flash,%,examples/ArduinoIoTCloud-Schedule<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/ArduinoIoTCloud-DeferredOTA<br>flash,%,examples/ArduinoIoTCloud-DeferredOTA<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:esp32:nano_nora,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0
arduino:mbed_edge:edge_control,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,64,0.01,0,0.0,,,,
arduino:mbed_giga:giga,0,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,14,0.0,0,0.0,14,0.0,0,0.0,14,0.0,0,0.0,14,0.0,0,0.0,14,0.0,0,0.0,14,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,0,0.0,0,0.0,0,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_opta:opta,0,0.0,0,0.0,0,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,,,,
arduino:renesas_portenta:portenta_c33,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:renesas_uno:unor4wifi,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,,,,,,,,,,,,
arduino:samd:mkr1000,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,,,,,
arduino:samd:mkrwifi1010,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,,,,,,,,,,,,

[pennam]

Any chance to use https://github.com/catchorg/Catch2/releases/download/v3.4.0/catch_amalgamated.hpp instead of the whole library? Using this PR it takes more time to compile the tests becase of increased build time related to Catch2 library.

cmake-improvements test build time 53s
master test build time 26s

[andreagilardoni]

In this link they suggest using the cmake approach, claiming that in the new version cmake integration is faster in terms of compiling time, wrt amalgamated version.

I run the tests on the following branches with:

cmake .
time make

You can find cmake-improvements-amalgamated in my fork of the repo

Branch	Time
master	29.047s
cmake-improvements	59.656s
cmake-improvements-amalgamated	39.765s

cmake-improvements-amalgamated requires to drop Cpp11 standard in favor for a newer one otherwise it won't compile. It seems that in the non amalgamated version we are not required to use cpp14, for some reasons.

I would personally prefer the cmake-improvements approach because he management of the dependency relies on cmake, instead of manual copy and paste of files from another repository.
Probably we still need to improve includes from test sources to perform better.