-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added methods to configure modbus server to existing data stuctures #52
Conversation
…ructs and example
Memory usage change @ f53379a
Click for full report table
Click for full report CSV
|
|
Thanks for this PR. I've been using it and loving it. |
Thanks for the feedback. Happy to help!
…On Wed, Jun 2, 2021, 08:46 Nicholas Stedman ***@***.***> wrote:
Thanks for this PR. I've been using it and loving it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#52 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE3JUNSEDZ2WJIBFAKR6JXLTQYYZPANCNFSM42AZ7OCQ>
.
|
I've tried signing the CLA several times. It still shows "not signed yet." |
Hi @ASolchen. Thanks so much for your pull request. The problem with the CLA is that the commit is by @testtechsolutions, not by your @ASolchen user. The email address of the user signing the CLA must match to that of the author of the commit. |
With memory being tight on most micro controllers, I felt like I shouldn't have to allocate memory for modbus to use, but instead point the server at existing data structures. If the structures are not of the same type, the user can cast it as such.