Fix: remove function definition for not implemented function "getTemperature". #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #27.
Hi @simonmicro, you're right, the function is not implemented ...
At first I though this would be quick to fix, but the more I dived into the existing library the more roadblocks I encountered.
The main issue is that this library is built around a sensor interface library provided by Bosch (BMI270-Sensor-API). And while the sensor provides a temperature sensor and it would be relatively easy to bypass the Bosch interface library to directly read it out doing so could create problems down the road (since then there would be direct chip access bypassing the Bosch interface library). Extending the Bosch interface library would have been the option, but boy is that one tailored for a specific use case. Given that I have neither the time nor the mandate to do this I'm going with the easiest option - removing the misleading prototype so that future users do not fall into the same trap.