Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder OTA error codes #24

Closed
wants to merge 1 commit into from
Closed

Conversation

pennam
Copy link
Collaborator

@pennam pennam commented Oct 23, 2023

@github-actions
Copy link

Memory usage change @ 48b60b0

Board flash % RAM for global variables %
arduino:esp32:nano_nora 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
esp32:esp32:esp32 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/OTA_Arduino_Server
flash
% examples/OTA_Arduino_Server
RAM for global variables
% examples/OTA_GitHub_Server
flash
% examples/OTA_GitHub_Server
RAM for global variables
% examples/NANO_ESP32_Blink
flash
% examples/NANO_ESP32_Blink
RAM for global variables
% examples/LOLIN_32_Blink
flash
% examples/LOLIN_32_Blink
RAM for global variables
%
arduino:esp32:nano_nora 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
esp32:esp32:esp32 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/OTA_Arduino_Server<br>flash,%,examples/OTA_Arduino_Server<br>RAM for global variables,%,examples/OTA_GitHub_Server<br>flash,%,examples/OTA_GitHub_Server<br>RAM for global variables,%,examples/NANO_ESP32_Blink<br>flash,%,examples/NANO_ESP32_Blink<br>RAM for global variables,%,examples/LOLIN_32_Blink<br>flash,%,examples/LOLIN_32_Blink<br>RAM for global variables,%
arduino:esp32:nano_nora,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,0,0.0,0,0.0,0,0.0,0,0.0,,,,,0,0.0,0,0.0

@arduino-libraries arduino-libraries deleted a comment from github-actions bot Oct 24, 2023
@pennam
Copy link
Collaborator Author

pennam commented May 22, 2024

@andreagilardoni should we go ahead with this or we can close it? This library will be used only for UNO R4 WiFi and error code reordering is handled here https://github.com/arduino-libraries/ArduinoIoTCloud/blob/335daf8ade5639a6aeb65f918ea4105014244c5c/src/ota/implementation/OTAUnoR4.cpp#L129 so i think we can close it.

@per1234 per1234 added type: enhancement Proposed improvement conclusion: declined Will not be worked on topic: code Related to content of the project itself labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: declined Will not be worked on topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants