Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression re report-size-deltas after updating actions/upload-artifact. #31

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix regression re report-size-deltas after updating actions/upload-artifact. #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/compile-examples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ jobs:
- examples/OTA_Arduino_Server
- examples/OTA_GitHub_Server
- examples/LOLIN_32_Blink
artifact-name-suffix: esp32-esp32-esp32
- board:
type: arduino_esp32
platforms: |
Expand All @@ -62,6 +63,7 @@ jobs:
- examples/OTA_Arduino_Server
- examples/OTA_GitHub_Server
- examples/NANO_ESP32_Blink
artifact-name-suffix: arduino-esp32-arduino_esp32

steps:
- name: Checkout
Expand Down Expand Up @@ -89,6 +91,6 @@ jobs:
- name: Save memory usage change report as artifact
uses: actions/upload-artifact@v4
with:
name: ${{ env.SKETCHES_REPORTS_PATH }}
name: sketches-report-${{ matrix.board.artifact-name-suffix }}
if-no-files-found: error
path: ${{ env.SKETCHES_REPORTS_PATH }}
4 changes: 2 additions & 2 deletions .github/workflows/report-size-deltas.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ jobs:
- name: Comment size deltas reports to PRs
uses: arduino/report-size-deltas@v1
with:
# The name of the workflow artifact created by the "Compile Examples" workflow
sketches-reports-source: sketches-reports
# Regex matching the names of the workflow artifacts created by the "Compile Examples" workflow
sketches-reports-source: ^sketches-report-.+
Loading