Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow caller to control when screen is updated #7

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

gilesp1729
Copy link
Contributor

Added two new calls startBuffering() and endBuffering(). By bracketing a sequence of GFX calls between these, the endWrite() is deferred to the end of the sequence and the display is only updated from the buffer once, rather than after every call.
This allows caller to remove flickering and draw smoothly, especially in the common case when the first call is to clear the screen.

Code that does not use these new routines works as before (there is an endWrite at the end of each GFX call)

Missing endWrites mentioned in PR #3 are incorporated here as well.

@CLAassistant
Copy link

CLAassistant commented Jul 3, 2024

CLA assistant check
All committers have signed the CLA.

@facchinm facchinm requested a review from alranel July 3, 2024 06:49
@per1234 per1234 added the enhancement New feature or request label Jul 3, 2024
@gilesp1729
Copy link
Contributor Author

I certainly am a Github user, and have signed the CLA, but this check keeps coming up on this PR (not on others I have, though)

@per1234
Copy link

per1234 commented Jul 12, 2024

Hi @gilesp1729. You can see the email address that is associated with the commits here:

https://api.github.com/repos/arduino-libraries/Arduino_GigaDisplay_GFX/commits/f37a8f23628d864c593ee5c09f9e3faa30cc2690

As the bot explained, that email address must be associated with your GitHub account. The email address is not currently associated with your GitHub account. This is how the CLA system verifies that the author of the commit (which might be different from the person who submitted a pull request) has signed the CLA.

You can learn how to add the email address to your GitHub account from this guide:

https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

not on others I have, though

The CLA check is something Arduino has set up in our repositories. When you submit PRs to repositories owned by other organizations or individuals, they might not have a CLA, or they might not have an automated system to check it.

@KurtE
Copy link

KurtE commented Sep 20, 2024

@gilesp1729 @per1234 in response to a user on the forum, I was about to suggest that something like this be
added to the library.

https://forum.arduino.cc/t/giga-shield-analog-display-updates/1302648

Was going to implement something like this and potentially a PR, but then I still have a pending bug fix PR from Feb.
So was not sure...

@facchinm facchinm merged commit a765a82 into arduino-libraries:master Dec 16, 2024
1 check passed
@facchinm
Copy link
Contributor

Merged, thanks! Sorry for the ling delay 🫶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants