Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make brightness range consistent #2

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Make brightness range consistent #2

merged 1 commit into from
Jun 13, 2024

Conversation

sebromero
Copy link
Contributor

This PR makes the orange LED brightness consistent with the RGB brightness.

@github-actions GitHub Actions
Copy link

Memory usage change @ ff2dd5c

Board flash % RAM for global variables %
arduino:esp32:nano_nora 🔺 0 - +112 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nano33ble 🔺 0 - +64 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 🔺 0 - +50 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_sense 🔺 0 - +64 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 🔺 0 - +64 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 🔺 0 - +52 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:renesas_uno:unor4wifi 🔺 0 - +32 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 0 - +516 0.0 - +0.2 0 - 0 0.0 - 0.0
Click for full report table
Board examples/BoardControl
flash		 % examples/BoardControl
RAM for global variables		 % examples/ChangeI2CAddress
flash		 % examples/ChangeI2CAddress
RAM for global variables		 % examples/FactoryReset
flash		 % examples/FactoryReset
RAM for global variables		 % examples/IndoorAirQuality
flash		 % examples/IndoorAirQuality
RAM for global variables		 % examples/OrangeLED
flash		 % examples/OrangeLED
RAM for global variables		 % examples/OutdoorAirQuality
flash		 % examples/OutdoorAirQuality
RAM for global variables		 % examples/RGBLED
flash		 % examples/RGBLED
RAM for global variables		 % examples/TemperatureHumidity
flash		 % examples/TemperatureHumidity
RAM for global variables		 % examples/UARTRead
flash		 % examples/UARTRead
RAM for global variables		 %
arduino:esp32:nano_nora 64 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 112 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nano33ble 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 64 0.01 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 50 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nicla:nicla_sense 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 64 0.01 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nicla:nicla_vision 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 64 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:renesas_uno:unor4wifi 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 32 0.01 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwifi1010 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 516 0.2 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/BoardControl<br>flash,%,examples/BoardControl<br>RAM for global variables,%,examples/ChangeI2CAddress<br>flash,%,examples/ChangeI2CAddress<br>RAM for global variables,%,examples/FactoryReset<br>flash,%,examples/FactoryReset<br>RAM for global variables,%,examples/IndoorAirQuality<br>flash,%,examples/IndoorAirQuality<br>RAM for global variables,%,examples/OrangeLED<br>flash,%,examples/OrangeLED<br>RAM for global variables,%,examples/OutdoorAirQuality<br>flash,%,examples/OutdoorAirQuality<br>RAM for global variables,%,examples/RGBLED<br>flash,%,examples/RGBLED<br>RAM for global variables,%,examples/TemperatureHumidity<br>flash,%,examples/TemperatureHumidity<br>RAM for global variables,%,examples/UARTRead<br>flash,%,examples/UARTRead<br>RAM for global variables,%
arduino:esp32:nano_nora,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,112,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nano33ble,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,64,0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,50,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_sense,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,64,0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:renesas_uno:unor4wifi,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,32,0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,516,0.2,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@sebromero sebromero force-pushed the orange-led-brightness branch from ff2dd5c to c97d7d1 Compare June 12, 2024 15:40
@github-actions GitHub Actions
Copy link

Memory usage change @ c97d7d1

Board flash % RAM for global variables %
arduino:esp32:nano_nora 🔺 0 - +88 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nano33ble 🔺 0 - +64 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 🔺 0 - +24 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_sense 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 🔺 0 - +64 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 🔺 0 - +28 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:renesas_uno:unor4wifi 🔺 0 - +16 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 0 - +488 0.0 - +0.19 0 - 0 0.0 - 0.0
Click for full report table
Board examples/BoardControl
flash		 % examples/BoardControl
RAM for global variables		 % examples/ChangeI2CAddress
flash		 % examples/ChangeI2CAddress
RAM for global variables		 % examples/FactoryReset
flash		 % examples/FactoryReset
RAM for global variables		 % examples/IndoorAirQuality
flash		 % examples/IndoorAirQuality
RAM for global variables		 % examples/OrangeLED
flash		 % examples/OrangeLED
RAM for global variables		 % examples/OutdoorAirQuality
flash		 % examples/OutdoorAirQuality
RAM for global variables		 % examples/RGBLED
flash		 % examples/RGBLED
RAM for global variables		 % examples/TemperatureHumidity
flash		 % examples/TemperatureHumidity
RAM for global variables		 % examples/UARTRead
flash		 % examples/UARTRead
RAM for global variables		 %
arduino:esp32:nano_nora 64 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 88 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nano33ble 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 64 0.01 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 24 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nicla:nicla_sense 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nicla:nicla_vision 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 64 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 28 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:renesas_uno:unor4wifi 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 16 0.01 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwifi1010 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 488 0.19 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/BoardControl<br>flash,%,examples/BoardControl<br>RAM for global variables,%,examples/ChangeI2CAddress<br>flash,%,examples/ChangeI2CAddress<br>RAM for global variables,%,examples/FactoryReset<br>flash,%,examples/FactoryReset<br>RAM for global variables,%,examples/IndoorAirQuality<br>flash,%,examples/IndoorAirQuality<br>RAM for global variables,%,examples/OrangeLED<br>flash,%,examples/OrangeLED<br>RAM for global variables,%,examples/OutdoorAirQuality<br>flash,%,examples/OutdoorAirQuality<br>RAM for global variables,%,examples/RGBLED<br>flash,%,examples/RGBLED<br>RAM for global variables,%,examples/TemperatureHumidity<br>flash,%,examples/TemperatureHumidity<br>RAM for global variables,%,examples/UARTRead<br>flash,%,examples/UARTRead<br>RAM for global variables,%
arduino:esp32:nano_nora,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,88,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nano33ble,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,64,0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,24,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_sense,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,28,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:renesas_uno:unor4wifi,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,16,0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,488,0.19,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@per1234 per1234 added the enhancement New feature or request label Jun 12, 2024
@sebromero sebromero merged commit de57a80 into main Jun 13, 2024
25 checks passed
@sebromero sebromero deleted the orange-led-brightness branch June 13, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebromero @per1234