-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setPoolServerIP
and setPoolServerAddress
methods
#104
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that
void NTPClient::setPoolServerIP(IPAddress poolServerIP) {
this->_poolServerIP = poolServerIP;
this->_poolServerName = NULL;
}
and
void NTPClient::setPoolServerAddress(IPAddress poolServerAddress) {
this->_poolServerIP = poolServerAddress;
this->_poolServerName = NULL;
}
are the same except for variable names.
I also added a void setPoolServerIP(IPAddress server_ip);
in my PR#102.
Christophe Catherine Slychan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
It appears that this PR has been held up for 1.5 years because the contributor hasn't signed the CLA. I need this functionality for a current project. Would it be possible for me to resubmit this and get it merged? |
Of course :) |
Looks like it's already been resubmitted multiple times it just hasn't been approved yet. Too bad. |
setPoolServerIP
and setPoolServerAddress
methods
add setPoolServerIP (accepts IP address), setPoolServerAddress (domain as well as IP address) methods
Fixes #103