Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setPoolServerIP and setPoolServerAddress methods #104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

keriszafir
Copy link

@keriszafir keriszafir commented Apr 26, 2020

add setPoolServerIP (accepts IP address), setPoolServerAddress (domain as well as IP address) methods

Fixes #103

Copy link

@WhymustIhaveaname WhymustIhaveaname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that

void NTPClient::setPoolServerIP(IPAddress poolServerIP) {
    this->_poolServerIP = poolServerIP;
    this->_poolServerName = NULL;
}

and

void NTPClient::setPoolServerAddress(IPAddress poolServerAddress) {
    this->_poolServerIP = poolServerAddress;
    this->_poolServerName = NULL;
}

are the same except for variable names.

I also added a void setPoolServerIP(IPAddress server_ip); in my PR#102.

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Christophe Catherine Slychan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@matthewdwatkins
Copy link

It appears that this PR has been held up for 1.5 years because the contributor hasn't signed the CLA. I need this functionality for a current project. Would it be possible for me to resubmit this and get it merged?

@keriszafir
Copy link
Author

Of course :)

@matthewdwatkins
Copy link

Looks like it's already been resubmitted multiple times it just hasn't been approved yet. Too bad.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Sep 10, 2023
@per1234 per1234 changed the title solve issue #103 Add setPoolServerIP and setPoolServerAddress methods Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add setPoolServerIP(IPAddress pool_server_ip)
5 participants