Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packet validity checks #145

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bmcdonnell
Copy link

Addresses #133. Improves upon #28 (not merged).

@CLAassistant
Copy link

CLAassistant commented May 23, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

Memory usage change @ cb073ba

Board flash % RAM for global variables %
esp8266:esp8266:huzzah 🔺 +112 - +112 +0.01 - +0.01 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Advanced
flash
% examples/Advanced
RAM for global variables
% examples/Basic
flash
% examples/Basic
RAM for global variables
%
esp8266:esp8266:huzzah 112 0.01 0 0.0 112 0.01 0 0.0
Click for full report CSV
Board,examples/Advanced<br>flash,%,examples/Advanced<br>RAM for global variables,%,examples/Basic<br>flash,%,examples/Basic<br>RAM for global variables,%
esp8266:esp8266:huzzah,112,0.01,0,0.0,112,0.01,0,0.0

@bmcdonnell bmcdonnell force-pushed the add-packet-validity-checks branch from cb073ba to 38a7dff Compare May 24, 2021 01:32
@bmcdonnell
Copy link
Author

I added a check of the fractional part of the reference time, since per RFC4330,

There will exist a 232-picosecond interval, henceforth ignored, every 136 years when the 64-bit field will be 0, which by convention is interpreted as an invalid or unavailable timestamp.

This time does roll over, so it can hit zero again. The reference time isn't updated frequently - it's not always getting updated in subsequent queries like the other timestamps - so this force push covers a very rare but still conceivable corner case (vs the previous revision).

@bmcdonnell bmcdonnell marked this pull request as draft May 24, 2021 01:53
@bmcdonnell
Copy link
Author

Marked as draft because I'm getting some NTP version 3 responses, which this was rejecting.

@github-actions
Copy link

Memory usage change @ 38a7dff

Board flash % RAM for global variables %
esp8266:esp8266:huzzah 🔺 +160 - +160 +0.02 - +0.02 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Advanced
flash
% examples/Advanced
RAM for global variables
% examples/Basic
flash
% examples/Basic
RAM for global variables
%
esp8266:esp8266:huzzah 160 0.02 0 0.0 160 0.02 0 0.0
Click for full report CSV
Board,examples/Advanced<br>flash,%,examples/Advanced<br>RAM for global variables,%,examples/Basic<br>flash,%,examples/Basic<br>RAM for global variables,%
esp8266:esp8266:huzzah,160,0.02,0,0.0,160,0.02,0,0.0

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants