-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added getFormattedDateTime method #207
Open
leodrivera
wants to merge
6
commits into
arduino-libraries:master
Choose a base branch
from
leodrivera:feat/getFormattedDateTime
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added getFormattedDateTime method #207
leodrivera
wants to merge
6
commits into
arduino-libraries:master
from
leodrivera:feat/getFormattedDateTime
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
May 9, 2024
leodrivera
force-pushed
the
feat/getFormattedDateTime
branch
from
May 10, 2024 03:51
4c44ac0
to
3b359eb
Compare
Memory usage change @ 3b359eb
Click for full report table
Click for full report CSV
|
leodrivera
force-pushed
the
feat/getFormattedDateTime
branch
from
May 23, 2024 04:36
a71b16c
to
5b5c317
Compare
Memory usage change @ 5b5c317
Click for full report table
Click for full report CSV
|
This was
linked to
issues
Jun 23, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement getFormattedDateTime, which has the advantage, when compared #94 that does not rely on external lib and parse more patterns. The #161 was used as base, however, I had to change all the calculation logic, as the results were not correct
Patterns
With this new method, getFormattedTime loses the meaning of existing, given that we can obtain the same result through the parameter "%H:%M:%S"
timeClient.getFormattedDateTime("%H:%M:%S")