Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MKR Vidor 4000 Serial.dtr #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sameer
Copy link

@sameer sameer commented Mar 19, 2020

This value is incorrect and prevents GPIO0 from being pulled at the right time, so esptool could not detect the board at all.
Now, it works perfectly with the added --no-stub parameter.
See this forum post for further discussion: https://forum.arduino.cc/index.php?topic=596970.0

@per1234 per1234 added the type: imperfection Perceived defect in any part of project label Mar 20, 2020
@JAndrassy
Copy link

JAndrassy commented Mar 20, 2020

again, this is Vigor specific. it would not work with Uno WiFi, MKR1010 and Nano 33 IoT.
the solution must be ifdefed for Vigor

#ifdef ARDUINO_SAMD_MKRVIDOR4000

@sameer
Copy link
Author

sameer commented Mar 20, 2020

again, this is Vigor specific. it would not work with Uno WiFi, MKR1010 and Nano 33 IoT.
the solution must be ifdefed for Vigor

#ifdef ARDUINO_SAMD_MKRVIDOR4000

Unless there is something I am missing, the statement is already wrapped in an ifdef, so it is Vidor specific as is.

#ifdef ARDUINO_SAMD_MKRVIDOR4000
-    FPGA.digitalWrite(FPGA_NINA_GPIO0, (Serial.dtr() == 1) ? HIGH : LOW);
+    FPGA.digitalWrite(FPGA_NINA_GPIO0, (Serial.dtr() == 0) ? HIGH : LOW);
#else

@sameer sameer changed the title Fix MKR Vidor 4000 Serial.dts Fix MKR Vidor 4000 Serial.dtr Mar 20, 2020
This value is incorrect and prevents GPIO0 from being pulled at the right time, so esptool could not detect the board at all.
Now, it works perfectly with the added --no-stub parameter.
See this forum post for further discussion: https://forum.arduino.cc/index.php?topic=596970.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants