-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WiFiServer::begin(port) and ctor without parameters #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory usage change @ 91c7db8
Click for full report table
Click for full report CSV
|
per1234
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
Sep 26, 2023
JAndrassy
force-pushed
the
server_begin_port
branch
from
October 9, 2023 05:35
91c7db8
to
8e9516e
Compare
Memory usage change @ 8e9516e
Click for full report table
Click for full report CSV
|
I added begin(port) and ctor without parameter to the PR for server.end, because begin(port) should call end(). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is my last (planed) PR for WiFiNINA
"the big picture of networking API"