Add non blocking WiFi.connect() method #264

hasenradball · 2023-11-11T08:33:17Z

why to update/benefits

with this rework a better and faster wifi connect is possible, because connect don't wait for final result.
Connecting goes on in background, so other tasks can be done during connecting.

With this approach we introduce the methods connect which is an non blocking wifi connect method

Now we can start the wifi connection without blocking..

Changes in methods

add new non blocking connect method

tested on

Arduino Nano 33 IOT

- added missing closing curly brace. Maybee wrongly deleted.

CLAassistant · 2023-11-11T08:33:24Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ hasenradball
❌ cmaglie
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

github-actions · 2023-11-11T08:41:11Z

Memory usage change @ 494c0f7

Board	flash	%	RAM for global variables	%
`arduino:mbed_nano:nanorp2040connect`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:megaavr:uno2018:mode=on`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrvidor4000`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwifi1010`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:nano_33_iot`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/ConnectWifi_waitForConnectResult` flash	%	`examples/ConnectWifi_waitForConnectResult` RAM for global variables	%
`arduino:mbed_nano:nanorp2040connect`	N/A	N/A	N/A	N/A
`arduino:megaavr:uno2018:mode=on`	N/A	N/A	N/A	N/A
`arduino:samd:mkrvidor4000`	N/A	N/A	N/A	N/A
`arduino:samd:mkrwifi1010`	N/A	N/A	N/A	N/A
`arduino:samd:nano_33_iot`	N/A	N/A	N/A	N/A

Click for full report CSV

Board,examples/AP_SimpleWebServer<br>flash,%,examples/AP_SimpleWebServer<br>RAM for global variables,%,examples/ConnectNoEncryption<br>flash,%,examples/ConnectNoEncryption<br>RAM for global variables,%,examples/ConnectWifi_waitForConnectResult<br>flash,%,examples/ConnectWifi_waitForConnectResult<br>RAM for global variables,%,examples/ConnectWithWEP<br>flash,%,examples/ConnectWithWEP<br>RAM for global variables,%,examples/ConnectWithWPA<br>flash,%,examples/ConnectWithWPA<br>RAM for global variables,%,examples/ConnectWithWPA2Enterprise<br>flash,%,examples/ConnectWithWPA2Enterprise<br>RAM for global variables,%,examples/ScanNetworks<br>flash,%,examples/ScanNetworks<br>RAM for global variables,%,examples/ScanNetworksAdvanced<br>flash,%,examples/ScanNetworksAdvanced<br>RAM for global variables,%,examples/SimpleWebServerWiFi<br>flash,%,examples/SimpleWebServerWiFi<br>RAM for global variables,%,examples/Tools/CheckFirmwareVersion<br>flash,%,examples/Tools/CheckFirmwareVersion<br>RAM for global variables,%,examples/Tools/FirmwareUpdater<br>flash,%,examples/Tools/FirmwareUpdater<br>RAM for global variables,%,examples/Tools/SerialNINAPassthrough<br>flash,%,examples/Tools/SerialNINAPassthrough<br>RAM for global variables,%,examples/WiFiChatServer<br>flash,%,examples/WiFiChatServer<br>RAM for global variables,%,examples/WiFiPing<br>flash,%,examples/WiFiPing<br>RAM for global variables,%,examples/WiFiSSLClient<br>flash,%,examples/WiFiSSLClient<br>RAM for global variables,%,examples/WiFiStorage<br>flash,%,examples/WiFiStorage<br>RAM for global variables,%,examples/WiFiUdpNtpClient<br>flash,%,examples/WiFiUdpNtpClient<br>RAM for global variables,%,examples/WiFiUdpSendReceiveString<br>flash,%,examples/WiFiUdpSendReceiveString<br>RAM for global variables,%,examples/WiFiWebClient<br>flash,%,examples/WiFiWebClient<br>RAM for global variables,%,examples/WiFiWebClientRepeating<br>flash,%,examples/WiFiWebClientRepeating<br>RAM for global variables,%,examples/WiFiWebServer<br>flash,%,examples/WiFiWebServer<br>RAM for global variables,%
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:megaavr:uno2018:mode=on,0,0.0,0,0.0,0,0.0,0,0.0,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrvidor4000,0,0.0,0,0.0,0,0.0,0,0.0,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

JAndrassy · 2023-11-11T09:06:03Z

if I want wait for connection result I can use begin. so waitForConnectionResult is not useful. esp8266 and esp32 have waitForConnectionResult because their begin is not blocking.
connect is useful if state() is checked later in loop() to do some communication over WiFi

hasenradball · 2023-11-11T09:12:24Z

@JAndrassy
If you don`t see ann benefit for waitForConnect then please look at PR #263.
With this approach there are indroduced small benefits.
And please read the explanations.
Thanks
Frank

JAndrassy · 2023-11-11T09:29:53Z

@263 changes begin. how is it related to waitForConnectResult?

hasenradball · 2023-11-11T09:48:27Z

@JAndrassy
It is related in this way:

return immediately if connected
is able to return -1 as inicate if timeout occurs

please take two min. to read the explanations in #263 .

If waitForConnectResult is no way for you, maybee we can improve the begin methods slightly.
😊

JAndrassy · 2023-11-11T09:55:17Z

I have no objection to connect.

there is nothing to improve in begin. it is a normal time for the esp32. around 3 seconds for the first and a 1 second for repeated begin

hasenradball · 2023-11-11T10:26:39Z

@JAndrassy maybee you looked in the wrong code.

Chances in begin are located in #263 .

And one hint to the benefit if a non blocking connect!
Why to wait if wifi is connected?
Use a non blocking connect method an let the wifi connecting in background.
Do meanwhile other stuff in setup.
And check the connection status at the end of setup.

JAndrassy · 2023-11-11T10:38:07Z

again. I have no objection to your connect.

I responded about begin to your "maybee we can improve the begin methods slightly."

hasenradball · 2023-11-11T12:04:17Z

@JAndrassy
Thanks for your reply.
I will rework it to add only the necessary changes.
Will you add the connect method from the existing branch to the master to be able to be used?

JAndrassy · 2023-11-11T12:36:30Z

I am just a contributor here. I would like my own PR be merged.

hasenradball · 2023-11-11T13:32:32Z

@JAndrassy can we then move further discussions for begin to #263 ?

hasenradball · 2023-11-11T16:38:41Z

Hi @JAndrassy,
I removed the waitForConnectResult, now only the non blocking connect method added here.

github-actions · 2023-11-11T16:48:05Z

Memory usage change @ 46b83a0

Board	flash	%	RAM for global variables	%
`arduino:mbed_nano:nanorp2040connect`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:megaavr:uno2018:mode=on`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrvidor4000`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwifi1010`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:nano_33_iot`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/ConnectWifi_waitForConnectResult` flash	%	`examples/ConnectWifi_waitForConnectResult` RAM for global variables	%
`arduino:mbed_nano:nanorp2040connect`	N/A	N/A	N/A	N/A
`arduino:megaavr:uno2018:mode=on`	N/A	N/A	N/A	N/A
`arduino:samd:mkrvidor4000`	N/A	N/A	N/A	N/A
`arduino:samd:mkrwifi1010`	N/A	N/A	N/A	N/A
`arduino:samd:nano_33_iot`	N/A	N/A	N/A	N/A

Click for full report CSV

Board,examples/AP_SimpleWebServer<br>flash,%,examples/AP_SimpleWebServer<br>RAM for global variables,%,examples/ConnectNoEncryption<br>flash,%,examples/ConnectNoEncryption<br>RAM for global variables,%,examples/ConnectWifi_waitForConnectResult<br>flash,%,examples/ConnectWifi_waitForConnectResult<br>RAM for global variables,%,examples/ConnectWithWEP<br>flash,%,examples/ConnectWithWEP<br>RAM for global variables,%,examples/ConnectWithWPA<br>flash,%,examples/ConnectWithWPA<br>RAM for global variables,%,examples/ConnectWithWPA2Enterprise<br>flash,%,examples/ConnectWithWPA2Enterprise<br>RAM for global variables,%,examples/ScanNetworks<br>flash,%,examples/ScanNetworks<br>RAM for global variables,%,examples/ScanNetworksAdvanced<br>flash,%,examples/ScanNetworksAdvanced<br>RAM for global variables,%,examples/SimpleWebServerWiFi<br>flash,%,examples/SimpleWebServerWiFi<br>RAM for global variables,%,examples/Tools/CheckFirmwareVersion<br>flash,%,examples/Tools/CheckFirmwareVersion<br>RAM for global variables,%,examples/Tools/FirmwareUpdater<br>flash,%,examples/Tools/FirmwareUpdater<br>RAM for global variables,%,examples/Tools/SerialNINAPassthrough<br>flash,%,examples/Tools/SerialNINAPassthrough<br>RAM for global variables,%,examples/WiFiChatServer<br>flash,%,examples/WiFiChatServer<br>RAM for global variables,%,examples/WiFiPing<br>flash,%,examples/WiFiPing<br>RAM for global variables,%,examples/WiFiSSLClient<br>flash,%,examples/WiFiSSLClient<br>RAM for global variables,%,examples/WiFiStorage<br>flash,%,examples/WiFiStorage<br>RAM for global variables,%,examples/WiFiUdpNtpClient<br>flash,%,examples/WiFiUdpNtpClient<br>RAM for global variables,%,examples/WiFiUdpSendReceiveString<br>flash,%,examples/WiFiUdpSendReceiveString<br>RAM for global variables,%,examples/WiFiWebClient<br>flash,%,examples/WiFiWebClient<br>RAM for global variables,%,examples/WiFiWebClientRepeating<br>flash,%,examples/WiFiWebClientRepeating<br>RAM for global variables,%,examples/WiFiWebServer<br>flash,%,examples/WiFiWebServer<br>RAM for global variables,%
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:megaavr:uno2018:mode=on,0,0.0,0,0.0,0,0.0,0,0.0,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrvidor4000,0,0.0,0,0.0,0,0.0,0,0.0,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

JAndrassy · 2023-11-11T17:52:37Z

I think you would achieve same as this connect with setting timeout to a very short time for begin

hasenradball · 2023-11-11T18:20:42Z

@JAndrassy

Could be, BUT if you look at the code, the value of timeout is hardcoded!
And if I want to use an non blocking connect method, I don't want to step into the src file first and make changes in the constructor!

Thats's not my way of smart software development!

That's the reason I wanted to add a method like waitForConnectResult because here you are able to define the timeout as function parameter!

But lets say with the both PR (#263 and #264) I would be happy because all is possible.

non blocking connect
and identify timeout during Wifi.begin()

JAndrassy · 2023-11-11T19:09:16Z

there is WiFi.setTimeout

hasenradball · 2023-11-11T19:18:24Z

Yes, you are right I saw it in the same time you wrote.

Is there an big point to add the connect methods?

I actually had an idea about simplify the connect methods by using the setTimeout() method like:

This would be much cleaner than this approach:

hasenradball · 2023-11-11T21:16:54Z

@JAndrassy using setTimeout(0)before begin()works fine.
So I would say there is no real need to introduce a connect()method.

cmaglie and others added 5 commits February 5, 2019 17:11

Added non-blocking connect method

5248504

add method waitForConnectResult to improve wifi connecting

7c8558e

merge branch non_blocking_connect and waitForConnect Result

43ec24c

Update WiFi.cpp

966ed86

- added missing closing curly brace. Maybee wrongly deleted.

Update ConnectWifi_waitForConnectResult.ino

494c0f7

hasenradball changed the title ~~Non blocking conn wait for connect res~~ Non blocking connect in combination with waitForConnectResult Nov 11, 2023

removed waitForConnectRewsult()

b67974a

hasenradball changed the title ~~Non blocking connect in combination with waitForConnectResult~~ Add non blocking WiFi.connect() method Nov 11, 2023

hasenradball added 2 commits November 11, 2023 17:30

adapt example

e6c0061

adapt example

46b83a0

per1234 added the type: enhancement Proposed improvement label Nov 13, 2023

per1234 added the topic: code Related to content of the project itself label Nov 13, 2023

hasenradball closed this Jan 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add non blocking WiFi.connect() method #264

Add non blocking WiFi.connect() method #264

hasenradball commented Nov 11, 2023 •

edited

Loading

CLAassistant commented Nov 11, 2023

github-actions bot commented Nov 11, 2023

JAndrassy commented Nov 11, 2023

hasenradball commented Nov 11, 2023 •

edited

Loading

JAndrassy commented Nov 11, 2023

hasenradball commented Nov 11, 2023

JAndrassy commented Nov 11, 2023 •

edited

Loading

hasenradball commented Nov 11, 2023

JAndrassy commented Nov 11, 2023

hasenradball commented Nov 11, 2023

JAndrassy commented Nov 11, 2023 •

edited

Loading

hasenradball commented Nov 11, 2023

hasenradball commented Nov 11, 2023

github-actions bot commented Nov 11, 2023

JAndrassy commented Nov 11, 2023 •

edited

Loading

hasenradball commented Nov 11, 2023 •

edited

Loading

JAndrassy commented Nov 11, 2023

hasenradball commented Nov 11, 2023 •

edited

Loading

hasenradball commented Nov 11, 2023

Add non blocking WiFi.connect() method #264

Add non blocking WiFi.connect() method #264

Conversation

hasenradball commented Nov 11, 2023 • edited Loading

why to update/benefits

Changes in methods

tested on

CLAassistant commented Nov 11, 2023

github-actions bot commented Nov 11, 2023

JAndrassy commented Nov 11, 2023

hasenradball commented Nov 11, 2023 • edited Loading

JAndrassy commented Nov 11, 2023

hasenradball commented Nov 11, 2023

JAndrassy commented Nov 11, 2023 • edited Loading

hasenradball commented Nov 11, 2023

JAndrassy commented Nov 11, 2023

hasenradball commented Nov 11, 2023

JAndrassy commented Nov 11, 2023 • edited Loading

hasenradball commented Nov 11, 2023

hasenradball commented Nov 11, 2023

github-actions bot commented Nov 11, 2023

JAndrassy commented Nov 11, 2023 • edited Loading

hasenradball commented Nov 11, 2023 • edited Loading

JAndrassy commented Nov 11, 2023

hasenradball commented Nov 11, 2023 • edited Loading

hasenradball commented Nov 11, 2023

hasenradball commented Nov 11, 2023 •

edited

Loading

hasenradball commented Nov 11, 2023 •

edited

Loading

JAndrassy commented Nov 11, 2023 •

edited

Loading

JAndrassy commented Nov 11, 2023 •

edited

Loading

JAndrassy commented Nov 11, 2023 •

edited

Loading

hasenradball commented Nov 11, 2023 •

edited

Loading

hasenradball commented Nov 11, 2023 •

edited

Loading