Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an automation to detect protobuf breaking changes #2422

Closed
3 tasks done
alessio-perugini opened this issue Nov 14, 2023 · 0 comments · Fixed by #2736
Closed
3 tasks done

Add an automation to detect protobuf breaking changes #2422

alessio-perugini opened this issue Nov 14, 2023 · 0 comments · Fixed by #2736
Assignees
@alessio-perugini
Labels
conclusion: resolved Issue was resolved topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Milestone
Arduino CLI v1.1.0

Comments

@alessio-perugini
Copy link
Contributor

Describe the request

After the v1.0.0 we should add some automation that checks if we're introducing breaking changes in the protobuf.
The ideal candidate is to use the buf breaking docs

Describe the current behavior

Arduino CLI version

Operating system

N/A

Operating system version

Additional context

No response

Issue checklist

  • I searched for previous requests in the issue tracker
  • I verified the feature was still missing when using the nightly build
  • My request contains all necessary details
@alessio-perugini alessio-perugini added the type: enhancement Proposed improvement label Nov 14, 2023
@alessio-perugini alessio-perugini self-assigned this Nov 14, 2023
@alessio-perugini alessio-perugini added this to the Arduino CLI 1.0.1 milestone Nov 14, 2023
@per1234 per1234 added the topic: infrastructure Related to project infrastructure label Oct 5, 2024
@alessio-perugini alessio-perugini linked a pull request Oct 18, 2024 that will close this issue
Use buf.build to manage our protobuf related activities #2736
Merged
6 tasks
@per1234 per1234 added the conclusion: resolved Issue was resolved label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alessio-perugini alessio-perugini

Labels
conclusion: resolved Issue was resolved topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
Arduino CLI v1.1.0
Development

Successfully merging a pull request may close this issue.

Use buf.build to manage our protobuf related activities arduino/arduino-cli
3 participants
@cmaglie @alessio-perugini @per1234