-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use buf.build
to manage our protobuf related activities
#2736
Use buf.build
to manage our protobuf related activities
#2736
Conversation
The latest Buf updates on your PR. Results from workflow Check Protocol Buffers / check (pull_request).
|
8f8fd5b
to
9496a56
Compare
9496a56
to
dc2c67a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2736 +/- ##
==========================================
- Coverage 67.67% 67.65% -0.02%
==========================================
Files 236 236
Lines 22327 22327
==========================================
- Hits 15109 15106 -3
- Misses 6030 6032 +2
- Partials 1188 1189 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
buf.build
to manage our protobuf related activities
573fdb0
to
1e35c6f
Compare
1e35c6f
to
e1794eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the PR with minor nitpicks in the comments and fixed a typo in the Taskfile job.
Outstanding work, buf
makes the grpc maintenance a lot easier!
🎉 🎉 🎉
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Use
buf
to manage the compilation, lint, formatting, breaking change detection of our protobuf filesWhat is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information
If this PR gets approved I will also have to update our template repo