Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci-lint #2378

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Update golangci-lint #2378

merged 3 commits into from
Nov 10, 2023

Conversation

alessio-perugini
Copy link
Contributor

@alessio-perugini alessio-perugini commented Oct 20, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (10c1411) 67.16% compared to head (16d22f3) 67.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2378   +/-   ##
=======================================
  Coverage   67.16%   67.16%           
=======================================
  Files         210      210           
  Lines       20523    20523           
=======================================
  Hits        13785    13785           
  Misses       5600     5600           
  Partials     1138     1138           
Flag Coverage Δ
unit 67.16% <72.30%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
arduino/cores/packagemanager/install_uninstall.go 58.00% <100.00%> (ø)
commands/board/details.go 89.18% <100.00%> (ø)
commands/board/listall.go 95.38% <100.00%> (ø)
commands/board/search.go 93.87% <100.00%> (ø)
commands/core/download.go 57.14% <100.00%> (ø)
commands/lib/resolve_deps.go 85.00% <100.00%> (ø)
commands/lib/search.go 96.25% <100.00%> (ø)
commands/sketch/archive.go 62.50% <100.00%> (ø)
commands/sketch/load.go 100.00% <100.00%> (ø)
commands/sketch/new.go 85.71% <100.00%> (ø)
... and 32 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessio-perugini alessio-perugini marked this pull request as ready for review October 20, 2023 14:22
@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Oct 23, 2023
@alessio-perugini alessio-perugini added the status: on hold Do not proceed at this time label Oct 27, 2023
@alessio-perugini alessio-perugini self-assigned this Oct 30, 2023
@alessio-perugini alessio-perugini removed the status: on hold Do not proceed at this time label Nov 10, 2023
@alessio-perugini alessio-perugini merged commit 17f0189 into master Nov 10, 2023
202 checks passed
@alessio-perugini alessio-perugini deleted the update-golangci-lint branch November 10, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants