Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the golang 'version' package internal #2767

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Nov 27, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

It makes the version package internal.

What is the current behavior?

The package version is publicly importable.

What is the new behavior?

The package version is private.

Does this PR introduce a breaking change, and is titled accordingly?

Strictly speaking, yes. By the way, this is a purely theoretical breaking change because the version package is useless outside the Arduino CLI, and there is no point in exporting it. I'll consider this patch more of a bug fix than a breaking change.

Other information

@cmaglie cmaglie self-assigned this Nov 27, 2024
@cmaglie cmaglie added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.52%. Comparing base (a9597d6) to head (865216e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2767      +/-   ##
==========================================
- Coverage   67.54%   67.52%   -0.02%     
==========================================
  Files         237      237              
  Lines       22362    22362              
==========================================
- Hits        15104    15101       -3     
- Misses       6066     6068       +2     
- Partials     1192     1193       +1     
Flag Coverage Δ
unit 67.52% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit 6dbff9f into arduino:master Nov 28, 2024
106 checks passed
@cmaglie cmaglie deleted the internalizing_version branch November 28, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants