Made the golang 'version' package internal #2767
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
It makes the
version
package internal.What is the current behavior?
The package
version
is publicly importable.What is the new behavior?
The package
version
is private.Does this PR introduce a breaking change, and is titled accordingly?
Strictly speaking, yes. By the way, this is a purely theoretical breaking change because the
version
package is useless outside the Arduino CLI, and there is no point in exporting it. I'll consider this patch more of a bug fix than a breaking change.Other information