[skip changelog] Do not allow extra paths in "archiveFileName" property in package_index.json #866
+121
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsora
suggested changes
Jul 24, 2020
There was a problem hiding this comment.
It would be nice to have a test that exposes the fixed bug in this PR @luigigubello @cmaglie WDYT?
cmaglie
force-pushed
the
do_not_allows_paths_in_resources_filename
branch
from
651824c to
aea3cc5
Compare
rsora
added
type: imperfection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replicates: arduino/Arduino#9649
@luigigubello