[WIP] Add opened examples to Open Recent menu #1376
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently when an example sketch is opened it is not added to the
Open Recent
menu.Change description
A temporary sketch can be added to the
Open Recent
menu if it doesn't include the stringsketch_
in the name.Other information
Closes #935.
Different solutions have been investigated to solve this problem, including:
Remove the return if a sketch is temporary in the
markAsRecentlyOpened
functionarduino-ide/arduino-ide-extension/src/node/sketches-service-impl.ts
Lines 280 to 281 in 5cb9166
Solution discarded because in this way also a new sketch created from
File -> New
is added to the recents.Change the
parentPath
of the new opened example without the creation of a temporary folder in thecloneExample
functionarduino-ide/arduino-ide-extension/src/node/sketches-service-impl.ts
Line 339 in 5cb9166
Solution discarded because the example is added directly to the sketchbook without saving it previously.
The current solution is not yet valid because a better way must be found to prevent an example from being considered a "standard" temporary file.
Reviewer checklist