Skip to content

Commit

Permalink
Configure PYTHONPATH via pytest configuration file
Browse files Browse the repository at this point in the history
Previously, the python:test task set PYTHONPATH via environment variable. That approach is fine when running the tests
via the task, but meant that PYTHONPATH was not correctly configured when running the tests via the interface of an IDE.
Each contributor would be forced to configure their IDE in order to allow it to run the tests successfully.

Configuring PYTHONPATH via the pytest.ini file makes this universal.
  • Loading branch information
per1234 committed Jun 13, 2024
1 parent d3b096d commit dbee8d0
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/workflows/test-python-poetry-task.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ on:
- "pyproject.toml"
- "compilesketches/tests/**"
- "**.py"
- "**/pytest.ini"
pull_request:
paths:
- ".github/workflows/test-python-poetry-task.ya?ml"
Expand All @@ -28,6 +29,7 @@ on:
- "pyproject.toml"
- "compilesketches/tests/**"
- "**.py"
- "**/pytest.ini"
schedule:
# Run periodically to catch breakage caused by external changes.
- cron: "0 12 * * WED"
Expand Down
1 change: 0 additions & 1 deletion Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,6 @@ tasks:
POETRY_GROUPS: dev,main
cmds:
- |
export PYTHONPATH="${PWD}/{{.PYTHON_PROJECT_PATH}}"
poetry run \
coverage run \
--source="{{.PYTHON_PROJECT_PATH}}" \
Expand Down
1 change: 1 addition & 0 deletions pytest.ini
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ filterwarnings =
# --capture=no - disable per-test capture
# --tb=long sets the length of the traceback in case of failures
addopts = --capture=no --tb=long --verbose
pythonpath = compilesketches

0 comments on commit dbee8d0

Please sign in to comment.