Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.0.1 ProyectilMx digitalIO #5409

Merged
merged 2 commits into from
Nov 26, 2024
Merged

v1.0.1 ProyectilMx digitalIO #5409

merged 2 commits into from
Nov 26, 2024

Conversation

misa3L994
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ ERROR: Arduino Lint found errors with https://github.com/misa3L994/digitalIO:

Linting library in digitalIO
INFO: No header file found matching library name (Proyectil_digitalIO.h). Best practices are for primary header filename
      to match library name.                                                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Proyectil digitalIO is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format   
         (Rule LP010)                                                                                             
WARNING: library.properties name Proyectil digitalIO contains spaces. Although supported, best practices is to not use  
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
ERROR: Library name Proyectil digitalIO is in use by a library in the Library Manager index. Each library must have a   
       unique name value. If your library is already in the index, use the "--library-manager update" flag.             
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format           
       (Rule LP017)                                                                                                     
WARNING: Invalid category field value Uncategorized in library.properties                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP038)                                                                                          
WARNING: Use of "Uncategorized" category value in library.properties. Please use one of the allowed categories.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP039)                                                                                          
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           

Linter results for project: 1 ERRORS, 5 WARNINGS

-------------------

Linting sketch in digitalIO/examples/buzz_test

Linter results for project: no errors or warnings

-------------------

Linting sketch in digitalIO/examples/digitalIO_test

Linter results for project: no errors or warnings

-------------------

Linting sketch in digitalIO/examples/histeresis

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 5 WARNINGS

@github-actions GitHub Actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @misa3L994
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234 per1234 assigned per1234 and unassigned per1234 Nov 13, 2024
@misa3L994 @per1234
Update URL of "Proyectil digitalIO"
7172b50 
The repository URL changed due to the project being transferred to the misa3L994 GitHub account.
@github-actions github-actions bot added topic: modification Change existing list entry and removed topic: submission Add library to the list labels Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/misa3L994/digitalIO:

Linting library in digitalIO
INFO: No header file found matching library name (Proyectil_digitalIO.h). Best practices are for primary header filename
      to match library name.                                                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Proyectil digitalIO is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format   
         (Rule LP010)                                                                                             
WARNING: library.properties name Proyectil digitalIO contains spaces. Although supported, best practices is to not use  
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Invalid category field value Uncategorized in library.properties                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP038)                                                                                          
WARNING: Use of "Uncategorized" category value in library.properties. Please use one of the allowed categories.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP039)                                                                                          
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           

Linter results for project: 0 ERRORS, 5 WARNINGS

-------------------

Linting sketch in digitalIO/examples/buzz_test

Linter results for project: no errors or warnings

-------------------

Linting sketch in digitalIO/examples/digitalIO_test

Linter results for project: no errors or warnings

-------------------

Linting sketch in digitalIO/examples/histeresis

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 5 WARNINGS

@per1234 per1234 mentioned this pull request Nov 13, 2024
Merged
per1234
per1234 reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @misa3L994 . I am confirming your request.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time.

After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

@per1234 per1234 added topic: URL change Change library repository URL status: pending backend Depends on backend maintenance operations and removed topic: modification Change existing list entry labels Nov 13, 2024
@arduino arduino deleted a comment from github-actions bot Nov 13, 2024
@misa3L994
Copy link
Contributor Author

@ArduinoBot

@github-actions GitHub Actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot added topic: modification Change existing list entry and removed topic: URL change Change library repository URL status: pending backend Depends on backend maintenance operations labels Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hi @misa3L994.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions GitHub Actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/misa3L994/digitalIO:

Linting library in digitalIO
INFO: No header file found matching library name (Proyectil_digitalIO.h). Best practices are for primary header filename
      to match library name.                                                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Proyectil digitalIO is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format   
         (Rule LP010)                                                                                             
WARNING: library.properties name Proyectil digitalIO contains spaces. Although supported, best practices is to not use  
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Invalid category field value Uncategorized in library.properties                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP038)                                                                                          
WARNING: Use of "Uncategorized" category value in library.properties. Please use one of the allowed categories.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP039)                                                                                          
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           

Linter results for project: 0 ERRORS, 5 WARNINGS

-------------------

Linting sketch in digitalIO/examples/buzz_test

Linter results for project: no errors or warnings

-------------------

Linting sketch in digitalIO/examples/digitalIO_test

Linter results for project: no errors or warnings

-------------------

Linting sketch in digitalIO/examples/histeresis

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 5 WARNINGS

@github-actions github-actions bot requested a review from per1234 November 13, 2024 18:10
@misa3L994 misa3L994 closed this Nov 13, 2024
@per1234 per1234 reopened this Nov 14, 2024
@per1234
Copy link
Contributor

per1234 commented Nov 14, 2024

@misa3L994 please leave the pull request open. As I explained already, the URL change you requested here must be accompanied by a manual operation by the database maintainer. They will do that when they find the time, but if you close the pull request then we won't be able to do it.

So please just be patient and leave the pull request alone!

If you have any questions or concerns, feel free to comment here and I'll provide assistance. Please note that, although this repository does have an automated system for handling library submissions, everything else here is done by humans, not by omniscient robots as some people seem to believe. I am a human, so you must communicate with me as a human.

@per1234 per1234 added topic: URL change Change library repository URL status: pending backend Depends on backend maintenance operations and removed topic: modification Change existing list entry labels Nov 14, 2024
@misa3L994
Copy link
Contributor Author

Sorry about that

@MatteoPologruto MatteoPologruto self-assigned this Nov 26, 2024
@github-actions github-actions bot added topic: modification Change existing list entry and removed topic: URL change Change library repository URL status: pending backend Depends on backend maintenance operations labels Nov 26, 2024
@github-actions github-actions bot removed the request for review from per1234 November 26, 2024 15:14
@github-actions GitHub Actions
Copy link
Contributor

Hi @MatteoPologruto.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions GitHub Actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/misa3L994/digitalIO:

Linting library in digitalIO
INFO: No header file found matching library name (Proyectil_digitalIO.h). Best practices are for primary header filename
      to match library name.                                                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Proyectil digitalIO is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format   
         (Rule LP010)                                                                                             
WARNING: library.properties name Proyectil digitalIO contains spaces. Although supported, best practices is to not use  
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Invalid category field value Uncategorized in library.properties                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP038)                                                                                          
WARNING: Use of "Uncategorized" category value in library.properties. Please use one of the allowed categories.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP039)                                                                                          
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           

Linter results for project: 0 ERRORS, 5 WARNINGS

-------------------

Linting sketch in digitalIO/examples/buzz_test

Linter results for project: no errors or warnings

-------------------

Linting sketch in digitalIO/examples/digitalIO_test

Linter results for project: no errors or warnings

-------------------

Linting sketch in digitalIO/examples/histeresis

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 5 WARNINGS

@github-actions github-actions bot requested a review from per1234 November 26, 2024 15:14
MatteoPologruto
MatteoPologruto approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2024/11/26 14:58:55 Loaded 7503 libraries from DB
Changing URL of library Proyectil digitalIO from https://github.com/misaproyectil/digitalIO.git to https://github.com/misa3L994/digitalIO.git
Success!

@MatteoPologruto MatteoPologruto merged commit bbc79c8 into arduino:main Nov 26, 2024
12 checks passed
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatteoPologruto MatteoPologruto MatteoPologruto approved these changes

@per1234 per1234 Awaiting requested review from per1234

Assignees

@MatteoPologruto MatteoPologruto

Labels
conclusion: resolved Issue was resolved topic: modification Change existing list entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@misa3L994 @per1234 @MatteoPologruto