Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SparkFun LG290P library #5418

Merged
merged 8 commits into from
Nov 13, 2024
Merged

Add SparkFun LG290P library #5418

merged 8 commits into from
Nov 13, 2024

Conversation

nseidle
Copy link
Contributor

@nseidle nseidle commented Nov 13, 2024

No description provided.

@github-actions github-actions bot requested review from per1234 and removed request for per1234 November 13, 2024 20:51
@github-actions github-actions bot added the topic: submission Add library to the list label Nov 13, 2024
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/sparkfun/SparkFun_LG290P_GNSS_Arduino_Library:

Linting library in SparkFun_LG290P_GNSS_Arduino_Library
INFO: No header file found matching library name (SparkFun_LG290P_Quadband_RTK_GNSS_Arduino_Library.h). Best practices  
      are for primary header filename to match library name.                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value SparkFun LG290P Quadband RTK GNSS Arduino Library is longer than the recommended 
         length of 16 characters.                                                                                       
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP010)                                                                                                   
WARNING: Library name SparkFun LG290P Quadband RTK GNSS Arduino Library contains "Arduino". This is superfluous.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format 
         (Rule LP014)                                                                                           
WARNING: library.properties name SparkFun LG290P Quadband RTK GNSS Arduino Library contains spaces. Although supported, 
         best practices is to not use spaces.                                                                           
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Library name SparkFun LG290P Quadband RTK GNSS Arduino Library contains "library". This is superfluous.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format 
         (Rule LP016)                                                                                           

Linter results for project: 0 ERRORS, 4 WARNINGS

-------------------

Linting sketch in SparkFun_LG290P_GNSS_Arduino_Library/examples/1. Basics/Device.Info

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_LG290P_GNSS_Arduino_Library/examples/1. Basics/Position.Velocity.Time

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_LG290P_GNSS_Arduino_Library/examples/2. Configuration/Commands

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_LG290P_GNSS_Arduino_Library/examples/2. Configuration/Constellations

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_LG290P_GNSS_Arduino_Library/examples/2. Configuration/SetFixInterval

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_LG290P_GNSS_Arduino_Library/examples/3. Satellites/Satellites

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_LG290P_GNSS_Arduino_Library/examples/4. Messages/Msg.Enable

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_LG290P_GNSS_Arduino_Library/examples/4. Messages/Msg.Subscribe

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_LG290P_GNSS_Arduino_Library/examples/5. Features/Odometer

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_LG290P_GNSS_Arduino_Library/examples/5. Features/PPS

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_LG290P_GNSS_Arduino_Library/examples/6. Accuracy and Protection/Position.Errors

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_LG290P_GNSS_Arduino_Library/examples/6. Accuracy and Protection/Protection

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_LG290P_GNSS_Arduino_Library/examples/7. Rover, Base, Survey/Set.Base.Rover.Mode

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_LG290P_GNSS_Arduino_Library/examples/7. Rover, Base, Survey/Survey.Fixed.Mode

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_LG290P_GNSS_Arduino_Library/examples/7. Rover, Base, Survey/Survey.Fixed.Mode.LLA

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_LG290P_GNSS_Arduino_Library/examples/7. Rover, Base, Survey/Survey.In.Mode

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_LG290P_GNSS_Arduino_Library/examples/8. Resets/Reset.Device

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_LG290P_GNSS_Arduino_Library/examples/8. Resets/Stop.Start.Engine

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_LG290P_GNSS_Arduino_Library/examples/9. NTRIP/NTRIP.Client

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_LG290P_GNSS_Arduino_Library/examples/9. NTRIP/NTRIP.Server

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_LG290P_GNSS_Arduino_Library/examples/9. NTRIP/NTRIP.Server.Survey.In

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 4 WARNINGS

@github-actions github-actions bot merged commit f8abd30 into arduino:main Nov 13, 2024
9 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/sparkfun/SparkFun_LG290P_GNSS_Arduino_Library/

github-actions bot pushed a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant