Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XY2-100 #5436

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Add XY2-100 #5436

merged 1 commit into from
Nov 16, 2024

Conversation

georgemihaila
Copy link
Contributor

Add implementation for XY2-100 laser scanner protocol

Add implementation for XY2-100 laser scanner protocol
@github-actions github-actions bot added the topic: submission Add library to the list label Nov 16, 2024
Copy link
Contributor

A problem was found with your submission https://github.com/georgemihaila/xy2-100

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @georgemihaila
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @georgemihaila. Thanks for your interest in contributing to the Arduino Library Manager index.

I see the bot reported a problem with your submission that will block its acceptance:

A problem was found with your submission https://github.com/georgemihaila/xy2-100

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

Please fix the problem so we can proceed with your submission.

You will need to do the following things:

  1. Create a new release or tag in the library repository.
  2. Add a comment here in the pull request thread that mentions @ArduinoBot.

After that, the automated checks will run again. Once those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Nov 16, 2024
@georgemihaila
Copy link
Contributor Author

@ArduinoBot

Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Nov 16, 2024
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/georgemihaila/xy2-100:

Linting library in xy2-100
INFO: No header file found matching library name (XY2-100.h). Best practices are for primary header filename to match   
      library name.                                                                                                     
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             
WARNING: Potentially misspelled examples folder name found: xy2-100/example                       
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD005)                                                                             

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

@github-actions github-actions bot merged commit b961ba7 into arduino:main Nov 16, 2024
12 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/georgemihaila/xy2-100/

github-actions bot pushed a commit that referenced this pull request Nov 16, 2024
@georgemihaila georgemihaila deleted the patch-1 branch November 16, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants