Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repositories.txt #5461

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Update repositories.txt #5461

merged 1 commit into from
Nov 22, 2024

Conversation

jmelabs
Copy link
Contributor

@jmelabs jmelabs commented Nov 22, 2024

Adding BuzzerMelody library to the list.

@github-actions github-actions bot added the topic: submission Add library to the list label Nov 22, 2024
Copy link
Contributor

A problem was found with your submission https://github.com/jmelabs/BuzzerMelody

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @jmelabs
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@jmelabs
Copy link
Contributor Author

jmelabs commented Nov 22, 2024

@ArduinoBot

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

A problem was found with your submission https://github.com/jmelabs/BuzzerMelody

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @jmelabs
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@jmelabs
Copy link
Contributor Author

jmelabs commented Nov 22, 2024

@ArduinoBot

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

A problem was found with your submission https://github.com/jmelabs/BuzzerMelody

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @jmelabs
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jmelabs. Thanks for your interest in contributing to the Arduino Library Manager index!

The reason for the check failure from the bot is a typo in the filename of your metadata file. I submitted a pull request to correct it:

jmelabs/BuzzerMelody#1

You will need to do the following things:

  1. Merge the PR correcting the filename.
  2. Bump the value of the version field in the library's library.properties metadata file.
  3. Create a new release or tag in the library repository.
  4. Add a comment here in the pull request thread that mentions @ArduinoBot.

After that, the automated checks will run again. Once those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@jmelabs
Copy link
Contributor Author

jmelabs commented Nov 22, 2024

@ArduinoBot

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/jmelabs/BuzzerMelody:

Linting library in BuzzerMelody
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 0 ERRORS, 3 WARNINGS

-------------------

@github-actions github-actions bot merged commit 7a5ba06 into arduino:main Nov 22, 2024
12 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/jmelabs/BuzzerMelody/

github-actions bot pushed a commit that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants