Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch repository URL for official AsyncTCP library to https://github.com/ESP32Async/AsyncTCP #5803

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mathieucarbou
Copy link
Contributor

@mathieucarbou mathieucarbou commented Jan 20, 2025

This request is a URL change for a repository.

With @me-no-dev, we are merging into one org (https://github.com/ESP32Async) the official AsyncTCP library (https://github.com/me-no-dev/AsyncTCP) with the community maintained for at https://github.com/mathieucarbou/AsyncTCP.

Both repos have been merged into one: https://github.com/ESP32Async/AsyncTCP, which is now the official repo for the AsyncTCP library.

@github-actions github-actions bot added the topic: modification Change existing list entry label Jan 20, 2025
Copy link
Contributor

Hi @mathieucarbou.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/ESP32Async/AsyncTCP:

Linting library in AsyncTCP
INFO: No header file found matching library name (Async_TCP.h). Best practices are for primary header filename to match 
      library name.                                                                                                     
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name Async TCP contains spaces. Although supported, best practices is to not use spaces.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format     
         (Rule LP015)                                                                                               
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in AsyncTCP/examples/Client

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 2 WARNINGS

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mathieucarbou . I am confirming your request.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time.

After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

@per1234 per1234 added topic: URL change Change library repository URL status: pending backend Depends on backend maintenance operations and removed topic: modification Change existing list entry labels Jan 21, 2025
@mathieucarbou
Copy link
Contributor Author

@per1234 : thanks! do I need to rebase at one point ? Or you will just re-apply the diff ?

@mathieucarbou
Copy link
Contributor Author

@per1234 : thanks! do I need to rebase at one point ? Or you will just re-apply the diff ?

Just saw #5807... 😆 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending backend Depends on backend maintenance operations topic: URL change Change library repository URL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants